On Mon, Nov 2, 2009 at 12:14 PM, Evan Laforge wrote:

Also +1.

On a related note, I think it's unfortunate that those functions are partial.  Like List.minimum and maximum, I always wind up wrapping them in a function that provides a default value.

I suppose that would be a different proposal though... but maybe if we're breaking compatibility anyway it would be a good time to, say, change them to 'IntMap k a -> (k, a) -> (k, a)'?  Actually, it seems that often 'IntMap k a -> b -> ((k, a) -> b) -> b' is more convenient, e.g. 'findMax fm Nothing Just', and you can always get the default val version back with 'id'.

I would prefer that partial functions return 'Maybe' - then I can pick whether or not I want 'Prelude.maybe' behavior or 'Data.Maybe.fromMaybe' behavior. I would prefer seeing findMax :: Map k a -> Maybe (k, a). It's also easier to read the function signature and know what is going to happen, rather than giving the function three parameters. But it sounds like we need a different ticket. Antoine

On Mon, Nov 02, 2009 at 01:30:49PM -0700, Evan Laforge wrote:

[ ross ]

...

Proposal: deprecate and then remove find, findIndex, findMin, findMax, deleteFindMin and deleteFindMax.

List.find? No thanks, I use that all the time.

No, Data.(Int)Map.find

For findMax, toDescList, which I thought was patched in a year ago, still doesn't appear in the latest version of collections, so as far as I know there's no alternative for it.

Containers is a core package, so it's tied to GHC's release cycle: one major release per year and only bugfixes between them.

On Mon, Nov 02, 2009 at 03:17:13PM -0800, Evan Laforge wrote:

On Mon, Nov 2, 2009 at 1:57 PM, Ross Paterson wrote:

...

On Mon, Nov 02, 2009 at 01:30:49PM -0700, Evan Laforge wrote:

...

[ ross ]

...

Proposal: deprecate and then remove find, findIndex, findMin, findMax, deleteFindMin and deleteFindMax.

List.find? No thanks, I use that all the time.

No, Data.(Int)Map.find

Yeah, I can't find it on http://www.haskell.org/ghc/docs/latest/html/libraries/containers/Data-Map.ht.... What's the signature?

My mistake: it's a private version of (!).

Evan Laforge wrote:

As far as findMin, toAscList works just as well, so fine, let's kill it. For findMax, toDescList, which I thought was patched in a year ago, still doesn't appear in the latest version of collections, so as far as I know there's no alternative for it.

The fact that a function can be written in terms of other things in the library is no excuse not to include it. If a program somewhere needs to find the smallest key in a map, then it should say so! findMin makes the intention of the programmer clear, while toAscList does not. Twan