Re: [GHC] #4277: Proposal: Significant performance improvements for Data.Map

This didn't follow the libraries process at all, and I've not actually
seen the final patch.
I understand the release deadlines are coming up, but clobbering the
workflow like this is frustrating.
Where is the final patch for review? Did Milan decide for us?
-- Don
----- Forwarded message from GHC

On 24/09/10 17:57, Don Stewart wrote:
This didn't follow the libraries process at all, and I've not actually seen the final patch.
I understand the release deadlines are coming up, but clobbering the workflow like this is frustrating.
Where is the final patch for review? Did Milan decide for us?
You're right, we've had less than 2 weeks to review Milan's latest proposals, and much less to decide on what to do about the INLINE issue. I take the blame: I should have asked Milan to hold off from pushing, sorry about that. Ian: could we back out *all* the patches to containers, and aim to get something into the next patchlevel release instead? Cheers, Simon
-- Don
----- Forwarded message from GHC
----- Date: Fri, 24 Sep 2010 16:49:04 -0000 From: GHC
Cc: glasgow-haskell-bugs@haskell.org Subject: Re: [GHC] #4277: Proposal: Significant performance improvements for Data.Map #4277: Proposal: Significant performance improvements for Data.Map --------------------------------------+------------------------------------- Reporter: dons | Owner: dons Type: proposal | Status: closed Priority: normal | Milestone: Component: libraries (other) | Version: 6.12.3 Resolution: fixed | Keywords: map, containers Testcase: | Blockedby: Difficulty: | Os: Unknown/Multiple Blocking: 4278, 4311 | Architecture: Unknown/Multiple Failure: Runtime performance bug | --------------------------------------+------------------------------------- Changes (by milan):
* status: new => closed * resolution: => fixed
Comment:
Applied with INLINE => INLINABLE changes.

On Sat, Sep 25, 2010 at 10:20:04AM +0100, Simon Marlow wrote:
Ian: could we back out *all* the patches to containers, and aim to get something into the next patchlevel release instead?
Currently the 7.0 branch has I think only the non-contentious changes (e.g. SATing, eta reduction, new insertLookupWithKey') but no new INLINE or INLINEABLE pragmas, and none of the patches from yesterday. Are you happy with that, or would you still like everything rolled back? Thanks Ian
participants (3)
-
Don Stewart
-
Ian Lynagh
-
Simon Marlow