proposal: reimplement Data.Graph.Inductive.Query.Dominators
Hi, (this is Trac ticket #2227, http://hackage.haskell.org/trac/ghc/ticket/2227) As pointed out at http://www.haskell.org/pipermail/haskell-cafe/2008-April/041739.html ff., Data.Graph.Inductive.Query.Dominators.dom is buggy. Furthermore, it's slow, so instead of submitting the quick fix from that thread, I've rewritten the module from scratch using a more efficient algorithm. The algorithm works by calculating the immediate dominators of the graph nodes first, so the patch also adds a function that returns those. It should be handy for flow graph analysis. Deadline for discussion ... is a week sufficient? That would be April 28th. regards, Bertram
bertram.felgenhauer:
Hi,
(this is Trac ticket #2227, http://hackage.haskell.org/trac/ghc/ticket/2227)
As pointed out at http://www.haskell.org/pipermail/haskell-cafe/2008-April/041739.html ff., Data.Graph.Inductive.Query.Dominators.dom is buggy. Furthermore, it's slow, so instead of submitting the quick fix from that thread, I've rewritten the module from scratch using a more efficient algorithm.
The algorithm works by calculating the immediate dominators of the graph nodes first, so the patch also adds a function that returns those. It should be handy for flow graph analysis.
Deadline for discussion ... is a week sufficient? That would be April 28th.
fgl is maintained by Martin Erwig, for these kind of non-core libraries its easier/faster to submit the patch directly to the maintainer. If the maintainer times out (possible here), we can declare it orphaned, and its free game. -- Don
On Mon, Apr 21, 2008 at 03:35:44PM -0700, Don Stewart wrote:
bertram.felgenhauer:
(this is Trac ticket #2227, http://hackage.haskell.org/trac/ghc/ticket/2227)
fgl is maintained by Martin Erwig, for these kind of non-core libraries its easier/faster to submit the patch directly to the maintainer.
Yes, library proposal tickets are for centrally maintained packages, i.e. those with a Maintainer field of libraries@haskell.org.
Don Stewart wrote:
fgl is maintained by Martin Erwig, for these kind of non-core libraries its easier/faster to submit the patch directly to the maintainer.
Well, the fgl version that I had in mind is hosted at http://darcs.haskell.org/packages/fgl it's an extra (but not, granted, a core) library in ghc, and the darcs repository lists libraries@haskell.org as the address to send patches to. Interestingly, at least part of the bug that prompted the discussion is not present in the version from Martin Erwig's homepage. On the other hand, that version does not work with ghc 6.8.2, due to MArray changes.
If the maintainer times out (possible here), we can declare it orphaned, and its free game.
Fair enough. Bertram
I wrote:
Interestingly, at least part of the bug that prompted the discussion is not present in the version from Martin Erwig's homepage.
Never mind. The bug is present, I just remembered it wrong.
If the maintainer times out (possible here), we can declare it orphaned, and its free game.
Fair enough.
I've contacted Martin Erwig now, and left a comment to that effect on the Trac ticket. regards, Bertram
participants (3)
-
Bertram Felgenhauer -
Don Stewart -
Ross Paterson