Performance bug in HTTP library affecting "cabal update"
Hi Ganesh and Mark, I just sent a pull request to the HTTP library [1] that dramatically improves the performance of "cabal update" (80s -> 8s on my machine). It would be nice if we could make a new release soon and compile the next Platform's "cabal-install" against it. Mark, any concerns? [1]: https://github.com/haskell/HTTP/pull/48
Woo! cabal update is always so slow for me.
On 9 December 2013 18:49, Thomas Schilling
Hi Ganesh and Mark,
I just sent a pull request to the HTTP library [1] that dramatically improves the performance of "cabal update" (80s -> 8s on my machine). It would be nice if we could make a new release soon and compile the next Platform's "cabal-install" against it.
Mark, any concerns?
[1]: https://github.com/haskell/HTTP/pull/48 _______________________________________________ Libraries mailing list Libraries@haskell.org http://www.haskell.org/mailman/listinfo/libraries
On Mon, Dec 9, 2013 at 6:49 PM, Thomas Schilling
Hi Ganesh and Mark,
I just sent a pull request to the HTTP library [1] that dramatically improves the performance of "cabal update" (80s -> 8s on my machine). It would be nice if we could make a new release soon and compile the next Platform's "cabal-install" against it.
+1, this would be nice. Thank you for fixing this, Thomas. -- () ascii ribbon campaign - against html e-mail /\ www.asciiribbon.org - against proprietary attachments
On 09/12/2013 17:49, Thomas Schilling wrote:
I just sent a pull request to the HTTP library [1] that dramatically improves the performance of "cabal update" (80s -> 8s on my machine). It would be nice if we could make a new release soon and compile the next Platform's "cabal-install" against it.
Mark, any concerns?
Nice catch! I've uploaded 4000.2.10 with your fix (and no other changes from 4000.2.9, which itself only has dependency changes since 4000.2.8). I'm fine with this going into the upcoming HP release, but I don't have a strong opinion either way myself. It is a code change perhaps quite late in the day, albeit a small one with significant benefits; it's not fixing an out and out regression but on the other hand the problem is likely getting worse over time as the hackage index gets larger. Cheers, Ganesh
Thanks for the quick response and the new release, Ganesh.
On 9 December 2013 21:13, Ganesh Sittampalam
On 09/12/2013 17:49, Thomas Schilling wrote:
I just sent a pull request to the HTTP library [1] that dramatically improves the performance of "cabal update" (80s -> 8s on my machine). It would be nice if we could make a new release soon and compile the next Platform's "cabal-install" against it.
Mark, any concerns?
Nice catch! I've uploaded 4000.2.10 with your fix (and no other changes from 4000.2.9, which itself only has dependency changes since 4000.2.8).
I'm fine with this going into the upcoming HP release, but I don't have a strong opinion either way myself.
It is a code change perhaps quite late in the day, albeit a small one with significant benefits; it's not fixing an out and out regression but on the other hand the problem is likely getting worse over time as the hackage index gets larger.
Cheers,
Ganesh
On Mon, Dec 9, 2013 at 8:13 PM, Ganesh Sittampalam
Nice catch! I've uploaded 4000.2.10 with your fix (and no other changes from 4000.2.9, which itself only has dependency changes since 4000.2.8).
I'm fine with this going into the upcoming HP release, but I don't have a strong opinion either way myself.
It is a code change perhaps quite late in the day, albeit a small one with significant benefits; it's not fixing an out and out regression but on the other hand the problem is likely getting worse over time as the hackage index gets larger.
Nice catch indeed! The fix seems straight-forward and has pretty important consequences. I think it would be worth pushing this into the HP release if we can.
participants (6)
-
Christopher Done -
Ganesh Sittampalam -
Henning Thielemann -
Mikhail Glushenkov -
Nicolas Wu -
Thomas Schilling