DarcsURL: http://darcs.haskell.org/ghc-6.8/packages/stm MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_" --=_ Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Thu Sep 20 21:56:33 =93=8C=8B=9E (=95W=8F=80=8E=9E) 2007 shelarcy <shelarc= y@gmail.com> * Add dropped STM invariants functions --=_ Content-Type: text/x-darcs-patch; name="add-dropped-stm-invariants-functions.dpatch" Content-Transfer-Encoding: quoted-printable Content-Description: A darcs patch for your repository! New patches: [Add dropped STM invariants functions shelarcy <shelarcy@gmail.com>**20070920125633] { hunk ./Control/Monad/STM.hs 27 + always, + alwaysSucceeds, } Context: [fix this test some more... Simon Marlow <simonmar@microsoft.com>**20070903133837] = [Add a dep on array Ian Lynagh <igloo@earth.li>**20070805200603] = [conc052 test is broken for profc/profasm (trac #1547) Ian Lynagh <igloo@earth.li>**20070718130955] = [Skip conc063 when fast Ian Lynagh <igloo@earth.li>**20070717114245 It's failing, but in a way that looks valid to me, so stop it tripping up the validate script. ] = [Fix test conc053: Don't use pattern sigs gratuitously Ian Lynagh <igloo@earth.li>**20070717014902] = [-fglasgow-exts is required due to type signature in pattern Simon Marlow <simonmar@microsoft.com>**20070607101102] = [--configure-option and --ghc-option are now provided by Cabal Ross Paterson <ross@soi.city.ac.uk>**20070604115937] = [Remove Makefile and package.conf.in (used in the old GHC build system) Ian Lynagh <igloo@earth.li>**20070524145834] = [Move STM-specific tests from testsuite/tests/ghc-regress/concurrent/should= _run Simon Marlow <simonmar@microsoft.com>**20070517090102] = [Follow Cabal changes in Setup.*hs Ian Lynagh <igloo@earth.li>**20070418121347] = [Fix -Wall warnings Ian Lynagh <igloo@earth.li>**20070411005022] = [Add missing case in removePrefix Ian Lynagh <igloo@earth.li>**20070411002558] = [parse (but don't pass on) options for ./configure Ian Lynagh <igloo@earth.li>**20070406153749] = [make Setup suitable for building the libraries with GHC Ian Lynagh <igloo@earth.li>**20061112214731] = [turn off TMVar and TMChan for non-GHC Ross Paterson <ross@soi.city.ac.uk>**20070401210122] = [fix typo in comment Ross Paterson <ross@soi.city.ac.uk>**20070401210044] = [Add missing modules to the .cabal file Ian Lynagh <igloo@earth.li>**20070401203812] = [Add documentation for TMVar. Spencer Janssen <sjanssen@cse.unl.edu>**20061211074318] = [Add documentation for TChan Spencer Janssen <sjanssen@cse.unl.edu>**20061211071201] = [TAG 6.6 release Ian Lynagh <igloo@earth.li>**20061011124740] = [TAG Version 2.1 Ian Lynagh <igloo@earth.li>**20061009114914] = [Bump version number Ian Lynagh <igloo@earth.li>**20061009114909] = [Add comment simonpj@microsoft.com**20061124101835] = [add boilerplate Setup.hs Ross Paterson <ross@soi.city.ac.uk>**20060928231526] = [Add Control.Concurrent.STM.TArray to the exposed modules of the STM packag= e (I'm assuming it's supposed to be exposed!) simonpj@microsoft.com**20060925152624] = [sequential implementation of revised semantics of catchSTM Ross Paterson <ross@soi.city.ac.uk>**20060904172921 = (This module is not used by GHC) ] = [bump version to 2.0 Simon Marlow <simonmar@microsoft.com>**20060811152819] = [update following changes to MArray Simon Marlow <simonmar@microsoft.com>**20060810100940] = [add Control.Monad.STM to package.conf.in Bertram Felgenhauer <int-e@gmx.de>**20060619073302] = [factor out a Control.Monad.STM module Ross Paterson <ross@soi.city.ac.uk>**20060615133443] = [offer a subset of the interface to sequential implementations Ross Paterson <ross@soi.city.ac.uk>**20060613142751] = [TAG Initial conversion from CVS complete John Goerzen <jgoerzen@complete.org>**20060112154138] = Patch bundle hash: f81215a5d844090ca64b07a034e40c2d89ba73d1 --=_-- .
On Thu, Sep 20, 2007 at 05:59:55AM -0700, shelarcy wrote:
[Add dropped STM invariants functions shelarcy <shelarcy@gmail.com>**20070920125633] { hunk ./Control/Monad/STM.hs 27 + always, + alwaysSucceeds, }
I'm a little lost - what were these functions dropped from? They aren't exported by Control.Monad.STM in GHC 6.6.1 either. I'm not overly familiar with the STM package, but this seems to be an interface change, so I think it ought to go through http://www.haskell.org/haskellwiki/Library_submissions Thanks Ian
Hi Ian, On Fri, 21 Sep 2007 00:18:32 +0900, Ian Lynagh <igloo@earth.li> wrote:
[Add dropped STM invariants functions shelarcy <shelarcy@gmail.com>**20070920125633] { hunk ./Control/Monad/STM.hs 27 + always, + alwaysSucceeds, }
I'm a little lost - what were these functions dropped from?
I think they dropped from GHC 6.8 branch and GHC 6.8.1 release.
They aren't exported by Control.Monad.STM in GHC 6.6.1 either.
They are GHC 6.8.x's new feature. So current GHC 6.6.1 and stm packages can't export them. http://www.haskell.org/pipermail/haskell/2006-October/018618.html I thought someone add them in GHC 6.7 developping phase. But anyone doesn't do it, and now we are in the GHC 6.8.1 Release Candidate phase. So, I send patch to add thses functions. I think this is important change for STM user. Because if these functions are dropped from GHC 6.8.1' release, they must also use GHC.Conc module instead of just using Control.Concurrent.STM (or Control.Monad.STM). And this causes same tragedy on GHC 6.6.x's Parallel Haskell again. Parallel Haskell dropped exporting pseq function when GHC 6.6 release time, so we must use bad interface until GHC 6.8.1 release. http://www.mail-archive.com/glasgow-haskell-users@haskell.org/msg10973.html
I'm not overly familiar with the STM package, but this seems to be an interface change, so I think it ought to go through http://www.haskell.org/haskellwiki/Library_submissions
Should I formalise this contribution? I thought STM package developper knows GHC 6.8.x's change, and just forgot adding functions to STM package. So I send just darcs patch. Best Regards. -- shelarcy <shelarcy hotmail.co.jp> http://page.freett.com/shelarcy/
I think shelarcy is right here. The point of release candidates is to identify bugs, including API bugs, in the release candidate. We freeze the API once we release. In this case, the functionality is implemented, and its API should be in the main STM API. thanks for catching this shelarcy! Simon | -----Original Message----- | From: libraries-bounces@haskell.org [mailto:libraries-bounces@haskell.org] On Behalf Of shelarcy | Sent: 20 September 2007 17:52 | To: Ian Lynagh | Cc: libraries@haskell.org | Subject: Re: darcs patch: Add dropped STM invariants functions | | Hi Ian, | | On Fri, 21 Sep 2007 00:18:32 +0900, Ian Lynagh <igloo@earth.li> wrote: | >> | >> [Add dropped STM invariants functions | >> shelarcy <shelarcy@gmail.com>**20070920125633] { | >> hunk ./Control/Monad/STM.hs 27 | >> + always, | >> + alwaysSucceeds, | >> } | > | > I'm a little lost - what were these functions dropped from? | | I think they dropped from GHC 6.8 branch and GHC 6.8.1 release. | | > They aren't exported by Control.Monad.STM in GHC 6.6.1 either. | | They are GHC 6.8.x's new feature. | So current GHC 6.6.1 and stm packages can't export them. | | http://www.haskell.org/pipermail/haskell/2006-October/018618.html | | I thought someone add them in GHC 6.7 developping phase. | But anyone doesn't do it, and now we are in the GHC 6.8.1 | Release Candidate phase. So, I send patch to add thses functions. | | I think this is important change for STM user. | Because if these functions are dropped from GHC 6.8.1' release, | they must also use GHC.Conc module instead of just using | Control.Concurrent.STM (or Control.Monad.STM). | | And this causes same tragedy on GHC 6.6.x's Parallel Haskell again. | Parallel Haskell dropped exporting pseq function when GHC 6.6 release time, | so we must use bad interface until GHC 6.8.1 release. | | http://www.mail-archive.com/glasgow-haskell-users@haskell.org/msg10973.html | | | > I'm not overly familiar with the STM package, but this seems to be an | > interface change, so I think it ought to go through | > http://www.haskell.org/haskellwiki/Library_submissions | | Should I formalise this contribution? | | I thought STM package developper knows GHC 6.8.x's change, and just forgot | adding functions to STM package. So I send just darcs patch. | | | Best Regards. | | -- | shelarcy <shelarcy hotmail.co.jp> | http://page.freett.com/shelarcy/ | _______________________________________________ | Libraries mailing list | Libraries@haskell.org | http://www.haskell.org/mailman/listinfo/libraries
Hi shelarcy, On Fri, Sep 21, 2007 at 01:52:19AM +0900, shelarcy wrote:
On Fri, 21 Sep 2007 00:18:32 +0900, Ian Lynagh <igloo@earth.li> wrote:
[Add dropped STM invariants functions shelarcy <shelarcy@gmail.com>**20070920125633] { hunk ./Control/Monad/STM.hs 27 + always, + alwaysSucceeds, }
http://www.haskell.org/pipermail/haskell/2006-October/018618.html
Ah, I see, some new functionality is not exported from the preferred module. OK, I've applied the patch - thanks for sending it! Thanks Ian
participants (3)
-
Ian Lynagh -
shelarcy -
Simon Peyton-Jones