On 09 February 2005 11:24, Ashley Yakeley wrote: Looks good. A few minor commnets:
System.Time.LeapSeconds:
I'd call it System.Time.TAI
module System.Time.Clock ( ... ) where
-- | standard Julian count of Earth days type JulianDay = Integer
newtype DiffTime = MkDiffTime Integer
Rather than exposing the constructor, I'd make it an abstract type with an instance of Integral. You probably want the Integral instance anyway, so that you can use overloaded literals, and then there's not much use for the constructor. Cheers, Simon
In article
<3429668D0E777A499EE74A7952C382D103238B8A@EUR-MSG-01.europe.corp.microso
ft.com>,
"Simon Marlow"
module System.Time.Clock ( ... ) where
-- | standard Julian count of Earth days type JulianDay = Integer
newtype DiffTime = MkDiffTime Integer
Rather than exposing the constructor, I'd make it an abstract type with an instance of Integral. You probably want the Integral instance anyway, so that you can use overloaded literals, and then there's not much use for the constructor.
Do you mean for DiffTime or for JulianDay? "System.Time.TAI" is probably better. -- Ashley Yakeley, Seattle WA
participants (2)
-
Ashley Yakeley -
Simon Marlow