Hi, I have a file produced by profiling that hp2graph doesn't like. It reports: Illegal token MARK at 104497 Aborted If I remove any single line in the sample immediately above line 104497 then hp2graph is happy, and produces a .ps file. Is there a limit on the number of functions that can be considered at any timepoint? I have 134 here. I've attached the file if it helps. The hp2graph I'm using came with nhc98 version 1.08, on a ix86-Linux machine. Amanda -- Amanda Clare http://users.aber.ac.uk/ajc99/ Tel: +44 (0)1970 621922 Fax: +44 (0)1970 622455 Dept. of Computer Science, University of Wales, Aberystwyth, SY23 3DB
Amanda,
I have a file produced by profiling that hp2graph doesn't like.
If I remove any single line in the sample immediately above line 104497 then hp2graph is happy, and produces a .ps file. Is there a limit on the number of functions that can be considered at any timepoint? I have 134 here.
It is a buffer length problem, but it isn't related to the number of
function symbols. Rather than removing a line, if you add a line,
or change the length any of the function symbols by a few characters,
the error goes away also.
Here is a workaround patch that simply extends the input buffer.
It doesn't fix the underlying bug, just makes it less likely that
you will bump into it.
Regards,
Malcolm
Index: src/hp2graph/lex.c
===================================================================
RCS file: /usr/src/master/nhc/src/hp2graph/lex.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 lex.c
--- src/hp2graph/lex.c 1999/10/11 11:50:38 1.1.1.1
+++ src/hp2graph/lex.c 2001/11/09 10:13:45
@@ -1,7 +1,7 @@
#include "hp2graph.h"
#include
Thanks for the patch. Sorry for the double posting, not sure why that happened. Another question about hp2graph: if I ask for retainers, it gives them in sets. This makes the key really long, and the graph is squashed up unreadably in a tiny part of the page. Could we have an option to print the key below the graph, or not print the key at all? See attached .ps file for an example. Amanda -- Amanda Clare http://users.aber.ac.uk/ajc99/ Tel: +44 (0)1970 621922 Fax: +44 (0)1970 622455 Dept. of Computer Science, University of Wales, Aberystwyth, SY23 3DB
Another question about hp2graph: if I ask for retainers, it gives them in sets. This makes the key really long, and the graph is squashed up unreadably in a tiny part of the page.
I see what you mean - your example graph was pretty bad, even with a retainer set of only size 4.
Could we have an option to print the key below the graph, or not print the key at all?
Well, not printing the key at all seems counter-productive! I suppose it could be printed differently - either in columns below the graph, on a separate page, or in the current position but split over several lines. Regards, Malcolm
Well, not printing the key at all seems counter-productive! I suppose it could be printed differently - either in columns below the graph, on a separate page, or in the current position but split over several lines.
Not printing it would be ok, because I'd just do 2 graphs, one with and one without, and use the key from one for the other. But yes, any of those would be good. And another thing to add to the wish list - the option to just use 1 in x of the sample points in the hp file for when you realise you've got too much detail and would like a more general view of the shape. Sometimes I wish I'd profiled with a larger interval, but it can take a long time to run it again, and it should be easy to skip samples from the hp file. And it would be nice if when collecting the profile, I could specify what filename I want the .hp file to have - for future reminder of what it was, and more importantly so I can run many different profiles of the same program at once and they don't all try to write to the same file (I have access to a beowulf cluster). Amanda -- Amanda Clare http://users.aber.ac.uk/ajc99/ Tel: +44 (0)1970 621922 Fax: +44 (0)1970 622455 Dept. of Computer Science, University of Wales, Aberystwyth, SY23 3DB
participants (2)
-
Amanda Clare -
Malcolm Wallace