September 2007 - xmonad

darcs patch: Fix float in Operations.hs (and 2 more)
by Karsten Schoelzel 09 Sep '07

09 Sep '07

Mon Sep 10 00:04:04 CEST 2007 Karsten Schoelzel <kuser(a)gmx.de> * Fix float in Operations.hs First, if float is called with window which is on a hidden workspace, then the window will remain on that hidden workspace. Let's have 2 screens s1 and s2 with windows [ a* ] and [ b*, c, d ], and the upper-left corner of d is on s1 (i'm not sure if this can happen with the current functions) Now call (float d). Then d becomes floating on s1 and the screens look like - [ d, a* ] and [ b, c* ] without the use of shiftWin - [ d, a* ] and [ b*, c ] with shiftWin thus leaving focus intact on the second screen. Mon Sep 10 00:29:30 CEST 2007 Karsten Schoelzel <kuser(a)gmx.de> * More focus fixes. Okay fix the focus with float once more. The following will hold now: - the currently focused window won't loose the focus - the window which gets floated, will be the focused window on the target workspace, unless it gets to the current screen, which was non-empty before, and wasn't the focused window on the current screen - if float moves a window from a workspace X to another one, the focus on X will be as if X was simply shifted away The behaviour seems to be quite complicated :-( Mon Sep 10 00:44:38 CEST 2007 Karsten Schoelzel <kuser(a)gmx.de> * Float focus final fix Now the focus should change more as expected: float w = (view current) . (shiftWin ws w) where current is the current screen/workspace shiftWin ws w is: - view the workspace w is on - set focus on w - shift ws - set focus back to window it was on that workspace unless w was focused

1 1

(no subject)
by allbery＠ece.cmu.edu 09 Sep '07

09 Sep '07

1 0

darcs patch: Unify Drag(UpDown)Pane
by Karsten Schoelzel 09 Sep '07

09 Sep '07

Tue Sep 4 23:03:12 CEST 2007 Karsten Schoelzel <kuser(a)gmx.de> * Unify Drag(UpDown)Pane

3 4

Window tags
by Karsten Schoelzel 08 Sep '07

08 Sep '07

Hi, today I added the ability to add tags to windows. Some uses which are possible with them right now: * move a tag group of windows to another workspace at once * get them back without switching to the other workspace * change focus only in the group of windows with a specified tag - if there is only one of them at the workspace this means specifically that you can jump to a specific window wherever the focus is and wherever the window is Would be nice to get tags assigned automatically, but i haven't thought about how to implement this ;-) As it is work in progress (docs and cleanup needed) I would welcome opinions suggestions as to what people might want to do with tagging. Most parts of the code are in a Contrib module but where are also changes in StackSet to store the tags therein. (Yesterday I wrote a similar tagging module which stored the tags in the X Server in a text-property of the window. But that turned out to be not very nice to work with. If anybody wants to see that code, just ask :-)) Regards, Karsten Example settings in Config.hs , ((modMask, xK_f ), withFocusedX (addTag "abc")) , ((modMask .|. controlMask, xK_f ), withFocusedX (delTag "abc")) -- Sink all windows with tag "abc" on all workspaces , ((modMask .|. shiftMask, xK_f ), withTaggedGlobalM "abc" sink) -- Move all windows with tag "abc" to workspace "2" , ((modWinMask, xK_f ), withTagged "abc" (shiftX "2")) -- Move all windows with tag "abc" from all workspaces to the current workspace , ((modWinMask .|. shiftMask, xK_f ), withTaggedGlobal "abc" shiftHere) -- Change focus with "abc" windows , ((modWinMask .|. controlMask, xK_f ), focusTaggedUp "abc") diff -rN -u old-xmonad/StackSet.hs new-xmonad/StackSet.hs --- old-xmonad/StackSet.hs 2007-09-08 00:36:44.000000000 +0200 +++ new-xmonad/StackSet.hs 2007-09-08 00:36:44.000000000 +0200 @@ -22,11 +22,11 @@ -- * Operations on the current stack -- $stackOperations peek, index, integrate, integrate', differentiate, - focusUp, focusDown, - focusWindow, tagMember, member, findIndex, + focusUp, focusDown, focusUp', + focusWindow, workspaces, tagMember, member, findIndex, -- * Modifying the stackset -- $modifyStackset - insertUp, delete, filter, + insertUp, delete, deletetmp, filter, -- * Setting the master window -- $settingMW swapMaster, swapUp, swapDown, modify, modify', float, sink, -- needed by users @@ -39,6 +39,7 @@ import Data.Maybe (listToMaybe) import qualified Data.List as L (delete,deleteBy,find,splitAt,filter) import qualified Data.Map as M (Map,insert,delete,empty) +import Data.Set (Set) -- $intro -- @@ -151,6 +152,7 @@ , visible :: [Screen i a sid sd] -- ^ non-focused workspaces, visible in xinerama , hidden :: [Workspace i a] -- ^ workspaces not visible anywhere , floating :: M.Map a RationalRect -- ^ floating windows + , windowtags :: M.Map a (Set i) -- ^ window tags } deriving (Show, Read, Eq) -- | Visible workspaces, and their Xinerama screens. @@ -208,7 +210,7 @@ -- Xinerama: Virtual workspaces are assigned to physical screens, starting at 0. -- new :: (Integral s) => [i] -> [sd] -> StackSet i a s sd -new wids m | not (null wids) && length m <= length wids = StackSet cur visi unseen M.empty +new wids m | not (null wids) && length m <= length wids = StackSet cur visi unseen M.empty M.empty where (seen,unseen) = L.splitAt (length m) $ map (flip Workspace Nothing) wids (cur:visi) = [ Screen i s sd | (i, s, sd) <- zip3 seen [0..] m ] -- now zip up visibles with their screen id @@ -453,9 +455,16 @@ -- * otherwise, delete doesn't affect the master. -- delete :: (Ord a, Eq s) => a -> StackSet i a s sd -> StackSet i a s sd -delete w s = s { current = removeFromScreen (current s) - , visible = map removeFromScreen (visible s) - , hidden = map removeFromWorkspace (hidden s) } +delete w s = s' { floating = M.delete w (floating s') + , windowtags = M.delete w (windowtags s') } + where s' = deletetmp w s + +-- only temporarily remove the window from the stack, thereby not destroying special +-- information saved in the Stackset +deletetmp :: (Ord a, Eq s) => a -> StackSet i a s sd -> StackSet i a s sd +deletetmp w s = s { current = removeFromScreen (current s) + , visible = map removeFromScreen (visible s) + , hidden = map removeFromWorkspace (hidden s) } where removeFromWorkspace ws = ws { stack = stack ws >>= filter (/=w) } removeFromScreen scr = scr { workspace = removeFromWorkspace (workspace scr) } @@ -495,5 +504,5 @@ shift :: (Ord a, Eq s, Eq i) => i -> StackSet i a s sd -> StackSet i a s sd shift n s | n `tagMember` s && n /= curtag = maybe s go (peek s) | otherwise = s - where go w = view curtag . insertUp w . view n . delete w $ s + where go w = view curtag . insertUp w . view n . deletetmp w $ s curtag = tag (workspace (current s)) TagWindows.hs ----------------------------------------------------------------------------- -- | -- Module : XMonadContrib.TagWindows -- Copyright : (c) Karsten Schoelzel <kuser(a)gmx.de> -- License : BSD -- -- Maintainer : Karsten Schoelzel <kuser(a)gmx.de> -- Stability : unstable -- Portability : unportable -- -- Functions for tagging windows and selecting them by tags. ----------------------------------------------------------------------------- module XMonadContrib.TagWindows ( -- * Usage -- $usage addTag, delTag, withTagged, withTaggedGlobal , withFocusedX, withTaggedM, withTaggedGlobalM, focusTaggedUp, shiftX, shiftHere ) where import Data.Set (Set) import qualified Data.Set as Set --import Data.Map (Map) import qualified Data.Map as Map import Data.List (intersect) import Control.Monad.State ( gets ) import StackSet hiding (filter) import Operations (windows) import Graphics.X11.Xlib import XMonad -- $usage -- a -> i -> StackSet i a s sd -> StackSet i a s sd getTags :: (Ord a) => a -> StackSet i a s sd -> Maybe (Set i) getTags w s = Map.lookup w (windowtags s) addTag :: (Ord a, Ord i) => i -> a -> i -> StackSet i a s sd -> StackSet i a s sd addTag t w _ s = s { windowtags = Map.insertWith (Set.union) w (Set.singleton t) (windowtags s) } delTag :: (Ord a, Ord i) => i -> a -> i -> StackSet i a s sd -> StackSet i a s sd delTag t w _ s = s { windowtags = Map.update (\x -> Just (Set.delete t x)) w (windowtags s) } hasTag :: (Ord a, Ord i) => i -> a -> StackSet i a s sd -> Bool hasTag t w s = case getTags w s of Nothing -> False (Just ts) -> Set.member t ts focusTaggedUp :: WorkspaceId -> X () focusTaggedUp t = windows (focusTaggedUp' t) focusTaggedUp' :: (Ord a, Eq s, Eq i, Ord i) => i -> StackSet i a s sd -> StackSet i a s sd focusTaggedUp' ta s | wt == [] = s | otherwise = modify' (focusUpWith (`elem` wt)) s where tagwins = Map.keys (Map.filter (Set.member ta) (windowtags s)) wt = (integrate' . stack . workspace . current $ s) `intersect` tagwins focusUpWith :: (a -> Bool) -> Stack a -> Stack a focusUpWith f (Stack t (l:ls) rs) = if f l then s else focusUpWith f s where s = Stack l ls (t:rs) focusUpWith f (Stack t [] rs) = if f x then s else focusUpWith f s where s = Stack x xs [] (x:xs) = reverse (t:rs) withTagged :: WorkspaceId -> (Window -> WorkspaceId -> WindowSet -> WindowSet) -> X () withTagged t f = do wset <- gets windowset let wspace = workspace . current $ wset taggedWins = filter (\w -> hasTag t w wset) (integrate' . stack $ wspace) case taggedWins of [] -> return () _ -> windows $ foldl1 (.) (map (\w -> f w (tag wspace)) taggedWins) withTaggedM :: WorkspaceId -> (Window -> X ()) -> X () withTaggedM t f = do wset <- gets windowset let wspace = workspace . current $ wset taggedWins = filter (\w -> hasTag t w wset) (integrate' . stack $ wspace) mapM_ f taggedWins withTaggedGlobal :: WorkspaceId -> (Window -> WorkspaceId -> WindowSet -> WindowSet) -> X () withTaggedGlobal t f = do wset <- gets windowset let wspaces = workspaces wset wins = concat $ map (\ws -> map (\w -> (w,tag ws)) (integrate' . stack $ ws)) wspaces taggedWins = filter (\(w,_) -> hasTag t w wset) wins case taggedWins of [] -> return () _ -> windows $ foldl1 (.) (map (\(w,tt) -> f w tt) taggedWins) withTaggedGlobalM :: WorkspaceId -> (Window -> X ()) -> X () withTaggedGlobalM t f = do tags <- gets (Map.toList . windowtags . windowset) let taggedWins = map (fst) $ (filter (\(_,wts) -> t `Set.member` wts) tags) mapM_ f taggedWins withFocusedX :: (Window -> WorkspaceId -> WindowSet -> WindowSet) -> X () withFocusedX f = do wset <- gets windowset let curtag = tag . workspace . current $ wset maybe (return ()) (\w -> windows (f w curtag)) (peek wset) shiftX :: (Ord a, Eq s, Eq i) => i -> a -> i -> StackSet i a s sd -> StackSet i a s sd shiftX to w from s | from `tagMember` s && to `tagMember` s && to /= from = go w | otherwise = s where go w' = view curtag . insertUp w' . view to . deletetmp w' . view from $ s curtag = tag (workspace (current s)) shiftHere :: (Ord a, Eq s, Eq i) => a -> i -> StackSet i a s sd -> StackSet i a s sd shiftHere w from s = shiftX (tag . workspace . current $ s) w from s

2 3

trouble with xmonad 0.3: mod-tab intermittently makes mouse clicks cease to work
by Zed Lopez 08 Sep '07

08 Sep '07

I tried Xmonad 0.3 last night. I have a double-monitor setup, configured as separate screens (I used this successfully with Xmonad 0.2.) I was only using one of them, with the FullScreen layout, and a bog-standard, uncustomized, no-extensions Xmonad 0.3. Occasionally, Mod-tabbing between screens resulted in mouse clicks doing nothing -- the mouse continued to move the cursor. Cycling through the windows again with mod-tab fixed it. I can't reproduce this at will -- like I said, it's intermittent. Is anyone else facing this?

6 8

darcs patch: add function and comment assisting use in resizing the...
by David Roundy 07 Sep '07

07 Sep '07

Here's an amend-recorded version with conflict fixed. david Sep 6 08:55:43 EDT 2007 David Roundy <droundy(a)darcs.net> * add function and comment assisting use in resizing the screen.

2 1

GenerateManpage.hs uses Haddock-unfriendly tokens
by Alex Tarkovsky 07 Sep '07

07 Sep '07

While using Andrea's Haddock hacks against darcs to generate documentation, I get: XMonadContrib/SetWMName.hs:"XMonadContrib/SetWMName.hs": 35:1: parse error in doc string: [TokSpecial '@',TokString " Java hack\n",TokPara] The offending line occurs inside a Haddock docstring: -- ((modMask .|. controlMask .|. shiftMask, xK_z), setWMName "LG3D") -- @@ Java hack The error happens because the token used by util/GenerateManpage.hs for parsing key binding descriptions from comments is "@@", and '@' is a reserved character in Haddock for enclosing code blocks. I'm surprised it doesn't blow up in places other than SetWMName.hs as well (Haddock seems buggy here). I propose changing the manpage parser token from "@@" to something which doesn't involve any of the reserved Haddock characters '/', ''', '`', '"', '@', and '<'. -- Alex Tarkovsky

2 1

darcs patch: simplify use of Combo.
by David Roundy 06 Sep '07

06 Sep '07

Thu Sep 6 14:07:39 EDT 2007 David Roundy <droundy(a)darcs.net> * simplify use of Combo.

2 3

darcs patch: add function and comment assisting use in resizing the...
by David Roundy 06 Sep '07

06 Sep '07

Here's a change I expect to find helpful when living in a VNC client (since I'm far from my primary computer, and my laptop is very wimpy). Basically it allows me to define a keybinding that unilaterally changes the screen size, regardless of what X thinks. Slightly hokey, but helpful. David Tue Sep 4 17:24:29 EDT 2007 David Roundy <droundy(a)darcs.net> * add function and comment assisting use in resizing the screen.

2 2

Issue 31 in xmonad: Documentation for new features in 0.3
by codesite-noreply＠google.com 05 Sep '07

05 Sep '07

Issue 31: Documentation for new features in 0.3 http://code.google.com/p/xmonad/issues/detail?id=31 Comment #1 by SpencerJanssen: Done, see http://xmonad.org Issue attribute updates: Status: Fixed -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings

1 0