Re: [xmonad] Re: patch: Unicode fix for XMonad.Hooks.EwmhDesktops

On Fri, Feb 20, 2009 at 09:52:22PM +0300, Khudyakov Alexey wrote:

On Friday 20 February 2009 19:53:30 Spencer Janssen wrote:

...

On Sat, Jan 17, 2009 at 07:57:44PM +0300, Khudyakov Alexey wrote:

...

Thanks to Gwern Branwen I was able to make darcs patch.

Note: XMonadContrib is not buildable without utf8-strings with this patch.

That part specifically is not acceptable -- if utf8-strings is to be a mandatory dependency, the .cabal file's dependencies must also be updated.

From taking a look at the EWMH specification, it seems we can't support it without properly supporting UTF-8. Therefore, I think it is worthwhile to add the dependency. Please submit a new patch that updates the .cabal file and turns the utf8-string optional dependency into a regular dependency.

Here are patches.

Fri Feb 20 21:33:18 MSK 2009 Khudyakov Alexey * Make utf8-string regular dependency

The reason for this is that EWMH specification require utf8 encoded strings.

Fri Feb 20 21:41:37 MSK 2009 Khudyakov Alexey * Properly encode destop names before sending them to X server in XMonad.Hooks.EwmhDesktops

Fri Feb 20 21:33:18 MSK 2009 Khudyakov Alexey * Make utf8-string regular dependency

The reason for this is that EWMH specification require utf8 encoded strings.

Fri Feb 20 21:41:37 MSK 2009 Khudyakov Alexey * Properly encode destop names before sending them to X server in XMonad.Hooks.EwmhDesktops

Applied, thanks. The next step is to remove all the #ifdef USE_UTF8 cruft from the modules.