On Sun, Feb 08, 2009 at 07:18:15PM -0700, Wirt Wolff wrote:
Before sending a patch to the ./xmonad/man/xmonad.hs sample file, I wanted to get some feedback. My understanding of the event hook is not great. ;-) Please suggest improvements and correct innacuracies.
I'll also update config archive on wiki.
* Add handleEvenHook comment, myEventHook and use in defaultConfig:
+------------------------------------------------------------------------ +-- Event handling: hunk ./man/xmonad.hs 226 +-- * EwmhDesktops users should change this to ewmhDesktopsEventHook +-- +-- Defines a custom handler function for X Events. The function should +-- return True if the default handler is to be run afterwards. To +-- combine Event Hooks use mappend or mconcat from Data.Monoid. +-- +myEventHook = handleEventHook
hunk ./man/xmonad.hs 287 + handleEventHook = myEventHook, *----------------------
This seems to be cyclical. A better definition for myEventHook: myEventHook = mempty Otherwise the patch looks good. Cheers, Spencer Janssen