Re: [xmonad] Summary of unapplied patches

Excellent! The Haskell Hackathon is kicking off in Utrecht in 2 days, and a few xmonad developers will be there. We'll go through this full list. Thanks for compiling it! Also, now is a good time for people to request contrib commit access!! -- Don vogt.adam:

Hello, I've looked over the patches pending for contrib, here are my conclusions and questions:

...

# 20090128004726: NoWrap export patch for use with X.L.MessageControl by quentin.moser@unifr.ch # 20090128013917: new XMonad.Layout.MessageControl module by quentin.moser@unifr.ch These apply cleanly, and seem useful enough.

...

# 20090209192718: add a regular expression matching manageHook by Justin Bogner Conflicts, and was rejected: http://thread.gmane.org/gmane.comp.lang.haskell.xmonad/7071

...

# 20090227065315: added colour themes by perlkat@katspace.org Applies cleanly, dons liked it, but it got missed somehow

...

# 20090303065449: Add replaceBorings to L.BoringWindows by Adam Vogt # 20090303065701: Add Apply message to L.WindowNavigation by Adam Vogt Still needed for SubLayouts, these are backwards compatible.

...

# 20090303065941: Rearrange a possibly overlapped pattern in L.Decoration by Adam Vogt Obsolete (it doesn't make a difference) # 20090303070251: Add the whole TabbedModifier patch by Adam Vogt Obsolete (Replaced by SubLayouts) # 20090303072624: Abuse L.Decoration by updating all decorations on an ExposeEvent by Adam Vogt Obsolete (Not needed with SubLayouts)

...

# 20090315001809: X.H.ManageDocks: Added manageDocksConfig by Braden Shepherdson There was no discussion, while there was supposed to be some.

Conf.{Gnome,Kde,Xfce,Desktop}Config that are already in contrib, so I don't think that this one is controversial, only redundant imho.

# 20090322215553: Remove excess whitespace in A.UpdatePointer by Adam Vogt # 20090322215811: Add TowardsCentre option to UpdatePointer by Adam Vogt # 20090322221456: Add promoteWarp event to L.MagicFocus by Adam Vogt Pending review and discussion.

# 20090325040528: More configurability for Layout.NoBorders (typeclass method) by Adam Vogt Is applied, I've told darcswatch to forget this one, but it still shows up... ____________________________________________________________________

Missing From Darcswatch:

OneBig layout http://www.haskell.org/pipermail/xmonad/2009-February/007438.html applies cleanly, but it should probably be changed to use Rationals instead of Floats for ideological reasons

Fix issue 205 http://www.haskell.org/pipermail/xmonad/2009-April/007686.html Applies cleanly

Placement of floating windows: http://www.haskell.org/pipermail/xmonad/2009-April/007729.html Still in progress, not quite ready due to issues when interacting with other manageHooks.

Prompt responds with Keypad Enter http://www.haskell.org/pipermail/xmonad/2009-April/007738.html applies cleanly

* X.H.DynamicLog: provides trim, inverse of pad http://www.haskell.org/pipermail/xmonad/2009-April/007739.html applies cleanly

Gridselect enhancements: http://www.haskell.org/pipermail/xmonad/2009-April/007743.html applies cleanly

Consolidate ThreeColumnsMiddle with Threecolumns http://www.haskell.org/pipermail/xmonad/2009-April/007751.html makes sense, I've made some suggestions/updates to this that should retain backwards compatibility

ComboP http://www.haskell.org/pipermail/xmonad/2009-April/007689.html Roman had some suggestions for this one _____________________________________________________________________

additional comments, refering to the last review here: http://www.haskell.org/pipermail/xmonad/2009-february/007256.html

...

# 20080710220410: xmonad.actions.dynamickeys: utilities to update key bindings at runtime by marco tãºlio gontijo e silva this applies cleanly, but it depends on this small addition to the core (that also applies cleanly): http://www.haskell.org/pipermail/xmonad/attachments/20080715/10686e7d/attach... There was no discussion of this. Does it offer anything over using XMonad.Util.Paste or submaps that call themselves??

...

* 20080926205838: dzenstatusbar by seanmce33 at gmail.com, * 20081002131304: layoutlogger, windowlogger, workspacelogger,mailddir Wirt has fixed these http://www.haskell.org/pipermail/xmonad/2009-April/007753.html

...

* 20081019140330: focusnth improvements fixed by aleksey artamonov ** blocked on maintainer. separate thread. Still the same?

---

perhaps it would be more convenient to darcs pull http://www.eng.uwaterloo.ca/~aavogt/xmonad/XMonadContrib

The clean patches described here should be in that repo, plus a couple others (ie. SubLayouts, which quite ready)

There are quite a few pending patches for the core of xmonad too...

Thanks for your contributions everybody, Adam _______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad