Re: [xmonad] darcs patch: hide the implementation type in "EwmhDes... (and 1 more)

On Mon, Sep 08, 2008 at 12:01:35PM +0200, Joachim Breitner wrote:

Hi,

I???ve merged this patch, and re-submit it now. Isn???t it nicer to have the exposed type less implementation-specific?

Greetings, Joachim

Tue Jun 10 21:29:18 CEST 2008 Joachim Breitner * hide the implementation type in "EwmhDesktopsLayout" Instead of exporting the EwmhDesktopsHook type, which is used internally, export a type alias for (HandleEvent EwmhDesktopsHook), so users don't have to update their xmonad.hs if the implementation changes.

It could also be wrapped in a newtype, instead of a "type", but that would require manual instances of the various classes, as ghc can automatically derive the LayoutClass instance.

Mon Sep 8 11:59:17 CEST 2008 Joachim Breitner * Merge "hide the implementation type in "EwmhDesktopsLayout""

Can we get this as a fresh patch? We try to avoid pushing conflicts because it can give darcs a headache. Also, I think EwmhDesktopsHook should still be exported, there is no good reason for it not to be. Cheers, Spencer Janssen