Re: [xmonad] patch: ShowWName flash window fixes

On 15:53 -0500 / 9 Mar, Brandon Allbery wrote: Yes, Increasing the visibility of the flash was my primary target here. The patch results in relatively more significant amount of padding in case of smaller sized tags. Also I think the horizontal padding makes it go better with the existing vertical pad. This is a subjective view, so we can have a configuration option which exposes a multiplier to a unit character length lets say swn_hz_pad . If this seems acceptable, I will post a patch for this. -- Rohan Jain

On Fri, Mar 9, 2012 at 15:42, wrote:

...

...

Mon Mar 5 22:15:17 IST 2012 crodjer@gmail.com * ShowWName: Increase horizontal padding for flash

Currently the flash window width leaves a very small amount of padding. This patch adds some extra horizontal width, governed by text width and length.

This patch seems to add smaller and smaller padding the larger the text inside. Am I reading that right? Is that reasonable?

If the idea is to make sure the window has a reasonable size, it makes sense to pad it larger for smaller internal text because it doesn't need (any/as much) padding if the text already forces it to have a reasonable size. ("Reasonable" defined as "easily visible")

-- brandon s allbery allbery.b@gmail.com wandering unix systems administrator (available) (412) 475-9364 vm/sms

_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad