Re: [xmonad] patches to use data-default

Hi Carlos. I'm sorry you had trouble building xmonad-contrib. Did you make sure to darcs pull and cabal install in your xmonad library directory to upgrade it? If you do this, none of the changes in this patch should be necessary. This also provides an instance of Default for XConfig, though as you observed it is not so polymorphic as to give one for (XConfig a) -- only for XConfig TheTypeCorrespondingToTheDefaultLayout. ~d On 2013-07-20 16:11, Carlos López-Camey wrote:

Hi, I'm sending a patch that makes the latest version of xmonad-contrib compile; it adds data-default in the cabal file and the necessary imports of Data.Default. 

Daniel, I also changed some def's to defaultConfig - I could not write an instance Default of (XConfig anyLayout). I'm sorry if I spoiled any of your code.

2013/6/27 Daniel Wagner

...

On 2013-06-27 19:08, Jesper Reenberg wrote: On 28 May 2013 03:47, Daniel Wagner wrote:

I've done my best to: * maintain backwards compatibility. Configs that use these symbols should generate a warning, but still work perfectly correctly. * ensure that all the places that used to export default values now also export "def", so that working configs can eliminate the warnings without changing their imports (or at worst change imports of defaultXPConfig, etc. to imports of def)

Seems that you have forgot to fix the warnings that this introduces? 

I have sent a patch fixing this warning, but for whatever reason it hasn't been applied yet. You can find it in the xmonad@ archives.

Cheers, ~d

_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad [1]

Links: ------ [1] http://www.haskell.org/mailman/listinfo/xmonad

_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad