adam vogt
Hello Christian,
I have a couple suggestions, mostly concerned with documentation:
I have done darcs send, but it seems it didn't worked :-( I just fixed the documentation in that patch.
Type signatures for top level declarations are mandatory.
Blocks of sample code should be prefixed with `>':
-- > foo x y z = ... -- > ....
Itemized lists need blank lines around each item.
Lastly, the hardcoded constants could be calculated from the strings you listed with `map (fromIntegral . fromEnum)'. Leave out the fromIntegral if [Int] is the result you're looking for.
let a = (map fromEnum "abc") :: [KeySym] <interactive>:1:13: Couldn't match expected type `KeySym' against inferred type `Int' In the first argument of `map', namely `fromEnum' In the expression: (map fromEnum "abc") :: [KeySym] In the definition of `a': a = (map fromEnum "abc") :: [KeySym] If you can give me a way around this type issue i will fix it with pleasure.
If it was a runtime performance concern, you could use template haskell to run that calculation at compile time.
No, i just was a type quirck, i couldn't get around I Just attached the patch. I hope it is the right format, i couldn't figure out how to get a patch out of this darcs without darcs send. greetz didi -- No documentation is better than bad documentation -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt.