Re: [xmonad] Adding side tabs to XMonad.Layout.Tabbed

Hi Arjun -- it's applied, thanks for the patch and followup! ~d On 2014-03-10 16:55, Arjun Comar wrote:

Hi all, Just wanted to check and see if there were any further issues with this patch.

Thanks, Arjun

On Wed, Feb 19, 2014 at 3:12 PM, Arjun Comar wrote:

...

Hi all, Here's an updated patch that switches TabbarLocation with Direction2D.

Thanks, Arjun

On Mon, Feb 17, 2014 at 6:32 PM, Arjun Comar wrote:

Hi Daniel, I can confirm that existing configs shouldn't break unless the user has behavior that operates on TabbarLocation (which seems weird, that kind of stuff really belongs in XMonad.Layout.Tabbed). If they *do* have that kind of behavior, they'll need to update their pattern matching to handle the LeftS/RightS cases.

The naming is weird, but it's to prevent conflicts with Either. I was going for a Leftside/Rightside mnemonic. I actually like Adam's idea of just using Direction2D. That should also not break user configs since the interface functions don't ask for Top/Bottom/etc. and instead have separate functions for each task.

Thanks, Arjun

On Mon, Feb 17, 2014 at 4:16 PM, adam vogt wrote: Hi Daniel and Arjun,

LeftS and RightS don't take arguments like Left and Right do. TabbarLocation could be defined in terms of

http://xmonad.org/xmonad-docs/xmonad-contrib/XMonad-Util-Types.html#t:Direct...

...

[1], but it's fine as-is too.

-- Adam

_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad [2]

Links: ------ [1] http://xmonad.org/xmonad-docs/xmonad-contrib/XMonad-Util-Types.html#t:Direct... [2] http://www.haskell.org/mailman/listinfo/xmonad