Re: [xmonad] darcs patches for tiled hinted mplayer with fullscreen working

* On Tuesday, July 06 2010, Tomas Janousek wrote:

Dear xmonad,

this is a patch bundle that makes MPlayer happy when not floating, including fullscreen support. This should fix #400.

...

2 patches for repository http://code.haskell.org/XMonadContrib:

Tue Jul 6 20:57:51 CEST 2010 Tomas Janousek * X.H.EwmhDesktops: advertise fullscreen in _NET_SUPPORTED and handle it by default

This is a bit questionable, I know. There must have been a reason why fullscreenEventHook isn't used by default, but I feel that it should be advertised only if it's used, so I did it this way. Should ewmh take a flag that can turn off fullscreen support? Is there a way to make the list of supported NETWM props easily extensible?

...

Tue Jul 6 20:59:25 CEST 2010 Tomas Janousek * X.L.LayoutHints: event hook to refresh on hints change

Without this patch, aspect ratio is respected only after a focus change or explicit refresh. That's annoying.

I've pushed the second patch. Regarding the first patch, I think it should be the default, but perhaps there should be a way to disable such options. So I'll leave it unapplied at least until there's been more discussion on whether we need more configurability. Adam