
On Tue, Feb 03, 2009 at 05:03:27PM +0100, Daniel Schoepe wrote:
Spencer Janssen wrote:
One thing that this patch doesn't really address is what it means to combine event hooks. As we use this functionality in contrib, we'll come upon the inevitable situation where a user wants to use two event hooks. We need to at least document the correct method, and probably provide an operator to do it. Perhaps Monoid could be used?
As a minor issue, I'd rather keep the name XMonad.Main.handle instead of defaultHandler.
Done. I changed the type to Event -> X All and added a note in the documentation that mappend should be used for combining them in most cases. (I also removed the handler rename) Here are the new patches(The actual functionality and the adaption of the contrib modules).
Tue Feb 3 17:00:46 CET 2009 Daniel Schoepe
* Adjustments to use the new event hook feature instead of Hooks.EventHook
Applied, thanks.