Re: [xmonad] one more layout

On Tue, Apr 14, 2009 at 6:38 AM, Roman Cheplyaka wrote:

* Konstantin Sobolev [2009-04-03 17:00:36-0400] There are several wishes to your code: 1. All non-trivial top-level functions should be documented (such as   swap, forwardToFocused etc.)

done

2. If you use some function from a different module (like   'differentiate' from Combo) you shouldn't copy-paste its code;   instead prepare a separate patch which adds that function to export   list and explain where you use that function in the patch   description. Later that function may be also moved to some module in   the Util section.

I got rid of broadcastPrivate, now there's only differentiate left. It's too specific to be used by anything else I think.

  Again, those functions (differentiate and broadcastPrivate from   Combo) are not documented there. Could you please write documentation   for them if you use them?

I've added some short description to differentiate.

3. You shouldn't advise to import XMonad.Util.WindowProperties; instead   you should re-export needed things (or even the whole module) from   your module. See XMonad.Layout.IM for example.

done

Sorry for a late response and thanks for your work!

thank you