11 Oct
2007
11 Oct
'07
2:42 p.m.
On Thu, Oct 11, 2007 at 11:04:48AM -0700, Eric Mertens wrote:
Hello,
I started using RotView recently, but I felt like the code was rather difficult to understand at a glance. I wanted to share the changes I made in case anyone else felt the same way.
Other than some minor code changes and library function usage issues, I did want to say that RotView does exactly what I wanted.
(This patch should introduce no new behavior.)
I'd say these changes are an improvement, although I think you've got a few too many variables defined for real clarity. Removing sortWs would only improve clarity: sorted = sortBy (comparing tag) (hidden ws) is quite clear. -- David Roundy Department of Physics Oregon State University