Re: [xmonad] Patch to add new Layout message

Here you go. You get one. :) On Wed, Sep 24, 2014 at 11:57 AM, Devin Mullins wrote:

Don't forget to reply-all. I was going to generate one for you, but code.haskell.org is done, making it difficult. Some other notes I probably should have mentioned last time:

1. I don't have commit rights to xmonad, so I can't approve. 2. Generally, the community is more conservative about xmonad core - especially adding new features. When something can be done in contrib instead, it usually is. 3. And yeah, if you get a chance to install darcs and `darcs get http://code.haskell.org/xmonad` http://code.haskell.org/xmonad and `darcs get http://code.haskell.org/XMonadContrib` http://code.haskell.org/XMonadContrib, you'll make comitters' lives easier.

Otherwise, looks reasonable. I, too, fall into the same bucket of either 1 or 2 master panes.

On Tue, Sep 23, 2014 at 12:01 PM, Mike Meyer wrote:

...

sendmail may or may not be set up correctly - I generally do mail in the cloud. Darcs isn't installed, the patches were against source gotten with "cabal get". Any chance I can get someone on the list to generate a darcs patch, or do I have to install darcs and figure out what to do to get to go from a patch file or patched source files to a darcs patch?

Thanks, Mike

On Tue, Sep 23, 2014 at 12:42 PM, Devin Mullins wrote:

...

Thanks, Mike. Patches should be darcs patches. If your sendmail is setup correctly, you can use `darcs send` to mail the list, otherwise `darcs send -O` will create a file you can attach or send.

On Tue, Sep 23, 2014 at 7:31 AM, Mike Meyer wrote:

...

I found the inc/dec masterN commands to be a bit clumsy, especially considering that I pretty much just use 1 client in the master pane most of the time, sometimes using 2 when I wanted to alternate between two windows rapidly. I just submitted issue #577 on the google code issue tracker that includes a patch to add a new Message for changing the client count.

The Message is called "SplitMaster", and has no arguments. It sets the client count of the master pane to 1 if it's not currently 1, thus providing a quick way to get back to that setting. It setgs the client count for the master pane to 2 if it's currently 1, effectively making it a toggle between the two modes of a split master pane and an full size master pane.

I'm not sure if that's the proper way to submit patches. If not, please let me know what I need to do to submit it properly. If it is, could I get somoen to consider it and either merge it (with whatever fixes it requires) or let me know what I can do to get it merged?

Thanks, Mike

_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad