Re: [xmonad] RFC: XMonad.Prompt.ConfirmPrompt module

I am greatly in favor of moving to git. Apologies for the laziness, but I've been sitting on some cleanup patches to one of my XMonadContrib modules for a year or two now, because I haven't taken the time to figure out how to push to darcs / get it reviewed / etc. My XMonad configuration has grown quite large with sections labeled "potential XMonadContrib module?". These weaknesses of github are pretty much only present when you are rebasing / force pushing the review branch. What do you mean by "no patch history"? The old commits are still visible, along with their comments. What is wrong with the comment system? I get notifications for comment replies, so I haven't experienced them being hidden. In my experience, the PR system works fine. Certainly worse exist, personally I've had quite bad experiences with gerrit. I realize that Torvalds himself takes issue with it, but it seems to work just fine for all the haskell projects on github (it seems like the majority of them). Is a philosophical issue like this really a good reason to ignore the positive network effects of hosting on github? People are familiar with github, and so this lowers the barrier to entry. . The hub tool helps quite a lot with reviewing PRs: https://github.com/github/hub It allows you to easily checkout a PR simply by copy pasting its URL. I think we could see a revitalization of XMonad if such barriers to contribution are lowered. I would certainly be more likely to contribute patches. -Michael On Thu, Mar 12, 2015 at 11:24 AM, Carsten Mattner wrote:

On Thu, Mar 12, 2015 at 6:37 PM, Brandon Allbery wrote:

...

On Thu, Mar 12, 2015 at 1:21 PM, Peter Jones wrote:

...

Carsten Mattner writes:

...

If a migration happens it should host the git repo on git.haskell.org, googlecode.com (where the issue tracker is) and wherever else,

Looks like the issue tracker will need to move somewhere too:

http://arstechnica.com/information-technology/2015/03/google-to-close-google...

Yep, just saw that and was drafting a "we need to move everything soonish" message....

I say move to git.haskell.org and phabricator.haskell.org as the primary place as github refuses to fix their code review system. Github's systems works enough to seem nice but falls down if you actually review code:

1. no patch history 2. horrendous comment system in reviews 3. new comments as replies to previous ones are hidden and hard to find if you don't manually look for them in the code comments

I don't want to be direct, but github's code review and comment system is superbad. _______________________________________________ xmonad mailing list xmonad@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad