On Fri, Apr 11, 2008 at 07:36:11AM -0700, David Roundy wrote:

On Fri, Apr 11, 2008 at 10:59:10PM +1000, ivan.miljenovic@gmail.com wrote:

...

Fri Apr 11 22:58:04 EST 2008 Ivan.Miljenovic@gmail.com * A better solution for choosing whether the tabbar should always be visible. Instead of the previous patch I sent, this patch alters the datatypes used so that the layouts in Tabbed take in a Bool parameter that sets whether or not the tabbar should always be shown. simpleTabbed and simpleTabbedBottom remain unchanged. arossato's, droundy's and sjanssen's configs have been updated to reflect these changes.

Why isn't this Bool a part of the theme? -- David Roundy Department of Physics Oregon State University

Themes are used for decorations other than tabbed -- this option doesn't make any sense for these decorations. Cheers, Spencer Janssen

On Fri, Apr 11, 2008 at 02:33:37PM -0500, Spencer Janssen wrote:

On Fri, Apr 11, 2008 at 07:36:11AM -0700, David Roundy wrote:

...

On Fri, Apr 11, 2008 at 10:59:10PM +1000, ivan.miljenovic@gmail.com wrote:

...

Fri Apr 11 22:58:04 EST 2008 Ivan.Miljenovic@gmail.com * A better solution for choosing whether the tabbar should always be visible. Instead of the previous patch I sent, this patch alters the datatypes used so that the layouts in Tabbed take in a Bool parameter that sets whether or not the tabbar should always be shown. simpleTabbed and simpleTabbedBottom remain unchanged. arossato's, droundy's and sjanssen's configs have been updated to reflect these changes.

Why isn't this Bool a part of the theme?

Themes are used for decorations other than tabbed -- this option doesn't make any sense for these decorations.

I suppose that's a philosophical point. But I do object to breaking the existing API. I'd much rather see an extra flag like this added as a new function (if we can't stick it in the Theme where it won't hurt anyone), so existing configs would continue working. The fact that this patch had to update three configs that don't use the new feature tells me it's broken. -- David Roundy Department of Physics Oregon State University

On Sat, Apr 12, 2008 at 04:03:14AM +0000, Ivan Miljenovic wrote:

David Roundy writes:

...

On Fri, Apr 11, 2008 at 02:33:37PM -0500, Spencer Janssen wrote:

...

On Fri, Apr 11, 2008 at 07:36:11AM -0700, David Roundy wrote:

...

Why isn't this Bool a part of the theme?

Themes are used for decorations other than tabbed -- this option doesn't make any sense for these decorations.

I suppose that's a philosophical point. But I do object to breaking the existing API. I'd much rather see an extra flag like this added as a new function (if we can't stick it in the Theme where it won't hurt anyone), so existing configs would continue working. The fact that this patch had to update three configs that don't use the new feature tells me it's broken.

I did it this way because that was how I interpreted sjanssen's suggestions on #xmonad. If you want, I can do another patch making these changes to the theme interface, and setting the boolean flag to false by default.

If I do this though, what should I call the Bool parameter in the theme? extraDeco ?

I don't know. You could pick something. I'd be more verbose than extraDeco, something like maybe alwaysDisplayDecorations? But that isn't my module, so you'd want to follow the style used there. Or you could define new functions to create tabs that are present even if there's only one window. -- David Roundy Department of Physics Oregon State University