Issue 388 in xmonad: Google Chrome's dialog changes size back and forth rapidly
Status: New Owner: ---- New issue 388 by wei.hoo: Google Chrome's dialog changes size back and forth rapidly http://code.google.com/p/xmonad/issues/detail?id=388 What steps will reproduce the problem? 1. Start Google Chrome/Chromium. 2. Go to Options -> Under the Hood -> Clear browsing data... 3. Or Options -> Personal Stuff -> Import data from another browser... What is the expected output? What do you see instead? A dialog pops up (assuming you've set up xmonad to float dialogs), but it's shaking all the time and basically useless. Tiling the dialog does make it usable, but it's just a workaround. What version of the product are you using? On what operating system? Darcs version on Arch. Are you using an xmonad.hs? Please attach it and the output of "xmonad --recompile". Please provide any additional information below. I'm not really sure whether to blame XMonad or Google Chrome. Attachments: xmonad.hs 9.5 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Comment #1 on issue 388 by wei.hoo: Google Chrome's dialog changes size back and forth rapidly http://code.google.com/p/xmonad/issues/detail?id=388 Chrome bug report: http://crbug.com/40580 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Comment #2 on issue 388 by evan@chromium.org: Google Chrome's dialog changes size back and forth rapidly http://code.google.com/p/xmonad/issues/detail?id=388 We set the geometry of these windows like this: GdkGeometry geometry; geometry.min_width = width; geometry.min_height = height; gtk_window_set_geometry_hints(window, GTK_WIDGET(window), &geometry, GDK_HINT_MIN_SIZE); It could be that height is -1. Perhaps we should be setting it to zero? Perhaps xmonad might like to handle this case appropriately anyway. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Comment #3 on issue 388 by evan@chromium.org: Google Chrome's dialog changes size back and forth rapidly http://code.google.com/p/xmonad/issues/detail?id=388 If you'd like to test it, change that line to geometry.min_height = max(height, 0); I use xmonad on my laptop and I've never run into this, but I'm using a pretty old version of xmonad and I probably haven't opened these dialogs since the above code was introduced. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Comment #4 on issue 388 by wei.hoo: Google Chrome's dialog changes size back and forth rapidly http://code.google.com/p/xmonad/issues/detail?id=388 @Evan, thanks. I believe you're referring to SetWindowSizeFromResources in gtk_util.cc, aren't you? I made the change but it didn't help. Running xprop on the "Clear browsing data..." dialog shows that the dialog gives both minimum size hint (600x434) and maximum size hint (369x434). Note that the minimum size is larger than the maximum. Is it wrong? It's as if XMonad is busy trying to honor both sizes. One more thing: since certain version, Chrome's popup dialogs automatically put themselves in the center in terms of Chrome's window, which I don't like. Where is the relevant code? Thanks! -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Comment #5 on issue 388 by wei.hoo: Google Chrome's dialog changes size back and forth rapidly http://code.google.com/p/xmonad/issues/detail?id=388 I completely removed the following code which "fixed" this issue: Index: chrome/browser/gtk/gtk_util.cc =========================================================== ======== --- chrome/browser/gtk/gtk_util.cc (revision 44042) +++ chrome/browser/gtk/gtk_util.cc (working copy) @@ -209,18 +209,6 @@ if (resizable) { gtk_window_set_default_size(window, width, height); - } else { - // For a non-resizable window, GTK tries to snap the window size - // to the minimum size around the content. We still want to set - // the *minimum* window size to allow windows with long titles to - // be wide enough to display their titles, but if GTK needs to - // make the window *wider* due to very wide controls, we should - // allow that too. - GdkGeometry geometry; - geometry.min_width = width; - geometry.min_height = height; - gtk_window_set_geometry_hints(window, GTK_WIDGET(window), - &geometry, GDK_HINT_MIN_SIZE); } gtk_window_set_resizable(window, resizable ? TRUE : FALSE); } Since XMonad doesn't show a title bar anyway, hopefully this change isn't going to break anything. However, I think the proper fix is to make sure the maximum size hint is greater than the minimum size hint. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Comment #6 on issue 388 by wei.hoo: Google Chrome's dialog changes size back and forth rapidly http://code.google.com/p/xmonad/issues/detail?id=388 I can answer my own question in #4. Some dialog creation functions call the CenterOverWindow function in gtk_util.cc which does the "evil" thing. I would rather like XMonad to place the dialog close to the mouse rather than in the center. So I simply commented out the body of that function. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Comment #7 on issue 388 by evan@chromium.org: Google Chrome's dialog changes size back and forth rapidly http://code.google.com/p/xmonad/issues/detail?id=388 I cannot retitle this bug, but I guess the appropriate title is something like: "Don't flash between sizes rapidly when the geometry hints are invalid". I will fix this issue Chrome-side.
Comment #8 on issue 388 by evan@chromium.org: Google Chrome's dialog changes size back and forth rapidly http://code.google.com/p/xmonad/issues/detail?id=388 This was fixed in Chromium. You can close the bug.
Updates: Status: WontFix Labels: Type-Enhancement Usability Comment #9 on issue 388 by wirtwo...@gmail.com: Google Chrome's dialog changes size back and forth rapidly http://code.google.com/p/xmonad/issues/detail?id=388 Marking as won't fix (for the xmonad side issues) since it's fixed in Chromium. Please feel free to re-open if other cases suggesting xmonad should handle this differently present themselves.
participants (1)
-
codesite-noreply＠google.com