darcs patch: we cannot change GContext of decfor with a function th...

here's a fix for the problem with Tabbed.hs and BadGC/BadDrawable errors. As
I said I'm just learning all this X programming so take it as a bug report!
Thanks for your kind attention.
ciao
andrea
Mon Jun 11 13:50:49 CEST 2007 Andrea Rossato

On Mon, Jun 11, 2007 at 02:00:52PM +0200, Andrea Rossato wrote:
here's a fix for the problem with Tabbed.hs and BadGC/BadDrawable errors. As I said I'm just learning all this X programming so take it as a bug report! Thanks for your kind attention.
This is definitely not a proper fix (as you say), but it may highlight the issue. The problem is that it does this simply by turning off a feature, which is the redrawing of the tabs when the title of the window changes. :( I don't quite buy your explanation of this error--but I'm only about 24 hours ahead of you in my knowledge of X and GContext, so I'm stumped also. I can verify that your patch does remove the error messages, but I just don't understand why there is an error here. David
Mon Jun 11 13:50:49 CEST 2007 Andrea Rossato
* we cannot change GContext of decfor with a function that uses the GContext of window created for the tab Tabbed.hs creates errors: xmonad: fatal error: request code=60, error code=13 Error: BadGC (invalid GC parameter) This patch should be a work around for the problem. Still, when XMonad is restarted the messages are still there (correct behaviour?) ... hunk ./Decoration.hs 37 - | thisw == decfor && t == propertyNotify = draw' + | thisw == decfor && t == propertyNotify = return () }
-- David Roundy http://www.darcs.net

On Mon, Jun 11, 2007 at 06:49:38AM -0700, David Roundy wrote:
I don't quite buy your explanation of this error--but I'm only about 24 hours ahead of you in my knowledge of X and GContext, so I'm stumped also. I can verify that your patch does remove the error messages, but I just don't understand why there is an error here.
well, I do not have what I would call a clear understanding of the issues, but when withGC w f = withDisplay $ \d -> do gc <- io $ createGC d w f d w gc io $ freeGC d gc is evaluated, w in createGC and gc in freeGC seems to be wrong. And this is event: | thisw == decfor && t == propertyNotify = draw' turns to be the case. you are right, though. what I was writing before was quite senseless. andrea

On Mon, 11 Jun 2007 14:00:52 +0200
Andrea Rossato
here's a fix for the problem with Tabbed.hs and BadGC/BadDrawable errors. As I said I'm just learning all this X programming so take it as a bug report! Thanks for your kind attention.
ciao andrea
Mon Jun 11 13:50:49 CEST 2007 Andrea Rossato
* we cannot change GContext of decfor with a function that uses the GContext of window created for the tab Tabbed.hs creates errors: xmonad: fatal error: request code=60, error code=13 Error: BadGC (invalid GC parameter) This patch should be a work around for the problem. Still, when XMonad is restarted the messages are still there (correct behaviour?)
There seems to be agreement that this patch is not a proper fix. Not applied. Cheers, Spencer Janssen
participants (3)
-
Andrea Rossato
-
David Roundy
-
Spencer Janssen