darcs patch: Compile with ghc7

1 patch for repository http://code.haskell.org/XMonadContrib:
Wed May 4 22:24:55 EEST 2011 Mats Rauhala

On Wed, May 4, 2011 at 3:36 PM, Mats Rauhala
1 patch for repository http://code.haskell.org/XMonadContrib:
Wed May 4 22:24:55 EEST 2011 Mats Rauhala
* Compile with ghc7 I'm not sure if someone was already working on getting xmonad-contrib to work with ghc7 and I hope I'm not stepping on anyones toes. Until now (at least I) it wasn't possible to record changes with ghc7, because of warnings emitted by the change to ghc7. There were a couple of warnings about -fglasgow-exts, a couple of orphan instances, and a couple of warnings about useless imports (which were there for haddock!).
I doubt that this is a perfect solution, and should be checked with a magnifying glass. There were pretty big changes to FlexibleManipulate.hs because the `type Pnt = (Double, Double)` caused orphan instances warning to be emitted. I hope someone would take their time to check the changes with ghc6 so that I didn't break anything with it. Gwen gave me a couple of tips, but there might be something else also.
This built on my 6.12 installation. If no one objects, I'll probably push it in a week or so. -- gwern http://www.gwern.net

On Wed, May 4, 2011 at 4:05 PM, Gwern Branwen
On Wed, May 4, 2011 at 3:36 PM, Mats Rauhala
wrote: 1 patch for repository http://code.haskell.org/XMonadContrib:
Wed May 4 22:24:55 EEST 2011 Mats Rauhala
* Compile with ghc7 I'm not sure if someone was already working on getting xmonad-contrib to work with ghc7 and I hope I'm not stepping on anyones toes. Until now (at least I) it wasn't possible to record changes with ghc7, because of warnings emitted by the change to ghc7. There were a couple of warnings about -fglasgow-exts, a couple of orphan instances, and a couple of warnings about useless imports (which were there for haddock!).
I doubt that this is a perfect solution, and should be checked with a magnifying glass. There were pretty big changes to FlexibleManipulate.hs because the `type Pnt = (Double, Double)` caused orphan instances warning to be emitted. I hope someone would take their time to check the changes with ghc6 so that I didn't break anything with it. Gwen gave me a couple of tips, but there might be something else also.
This built on my 6.12 installation. If no one objects, I'll probably push it in a week or so.
No objections, so I have pushed to c.h.o. Thanks for the patch. -- gwern http://www.gwern.net

* On Wednesday, May 04 2011, Mats Rauhala wrote:
1 patch for repository http://code.haskell.org/XMonadContrib:
Wed May 4 22:24:55 EEST 2011 Mats Rauhala
* Compile with ghc7 I'm not sure if someone was already working on getting xmonad-contrib to work with ghc7 and I hope I'm not stepping on anyones toes. Until now (at least I) it wasn't possible to record changes with ghc7, because of warnings emitted by the change to ghc7. There were a couple of warnings about -fglasgow-exts, a couple of orphan instances, and a couple of warnings about useless imports (which were there for haddock!).
I doubt that this is a perfect solution, and should be checked with a magnifying glass. There were pretty big changes to FlexibleManipulate.hs because the `type Pnt = (Double, Double)` caused orphan instances warning to be emitted. I hope someone would take their time to check the changes with ghc6 so that I didn't break anything with it. Gwen gave me a couple of tips, but there might be something else also.
Mats, Another option for FlexibleManipulate is to define + - * / etc. without writing a Num instance. This leaves two unpleasant spots: imports and the one location where the math is with Double. See attached copy. A third option would be to use newtype Pnt = P (Double, Double), with similar instances. Adam

This 1-patch bundle was just applied to http://code.haskell.org/XMonadContrib:
20110504192455 Mats Rauhala
participants (4)
-
Adam Vogt
-
darcswatch@nomeata.de
-
Gwern Branwen
-
Mats Rauhala