Re: [xmonad] darcs patch: Add Stoppable layout for power saving (and 1 more)

newer
Patch to add new Layout message

older
darcs patch: X.A.Navigation2D: add...

Anton Vorontsov

23 Sep 2014 23 Sep '14

1:44 p.m.

On Mon, Sep 01, 2014 at 08:02:58AM +0000, Anton Vorontsov wrote:

...

In this version I addressed further comments by Paul Fertser, plus implemented the remote/local clients identification scheme that I was talking about: it is in XMonad.Util.RemoteWindows module with documentation and all.

I split the work into two logical changes, for easier review and so that the first patch won't depend on the second.

Just a friendly ping on this one. :) Thanks, Anton

Show replies by date

Devin Mullins

26 Sep 26 Sep

10:53 p.m.

New subject: darcs patch: Add Stoppable layout for power saving (and 1 more)

Brandon/Paul - ok to submit? I haven't reviewed this code, but I'll take your words on it. On Tue, Sep 23, 2014 at 10:44 AM, Anton Vorontsov wrote:

...

On Mon, Sep 01, 2014 at 08:02:58AM +0000, Anton Vorontsov wrote:

...
In this version I addressed further comments by Paul Fertser, plus implemented the remote/local clients identification scheme that I was talking about: it is in XMonad.Util.RemoteWindows module with documentation and all.

I split the work into two logical changes, for easier review and so that the first patch won't depend on the second.

Just a friendly ping on this one. :)

Thanks,

Anton _______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad

Brandon Allbery

10:57 p.m.

New subject: darcs patch: Add Stoppable layout for power saving (and 1 more)

On Fri, Sep 26, 2014 at 10:53 PM, Devin Mullins wrote:

...

Brandon/Paul - ok to submit? I haven't reviewed this code, but I'll take your words on it.

On some level I kinda dislike the whole idea, but (a) I can certainly see its usefulness, and (b) as long as users are aware of the caveats involved (cut and paste was mentioned; also note that anything that is holding open a network connection will probably catch an RST on resume if suspended for too long) it's up to them whether to use it or not. -- brandon s allbery kf8nh sine nomine associates allbery.b@gmail.com ballbery@sinenomine.net unix, openafs, kerberos, infrastructure, xmonad http://sinenomine.net

Devin Mullins

27 Sep 27 Sep

2:51 a.m.

New subject: darcs patch: Add Stoppable layout for power saving (and 1 more)

Well, okay, there are plenty of modules in contrib that I would never use (and for that matter, several things in core I disable or ignore). As long as: 1. The code is clean. 2. It won't segfault. 3. It's gotchas are well-documented. Then I'm happy with it. From a quick glance, it appears so. The advice in $usage to do `layoutHook def ||| stoppable (layoutHook def)` (thereby doubling your list of layouts?) seems a bit weird, but maybe I'm misunderstanding it. Applied. On Fri, Sep 26, 2014 at 7:57 PM, Brandon Allbery wrote:

...

On Fri, Sep 26, 2014 at 10:53 PM, Devin Mullins wrote:

...
Brandon/Paul - ok to submit? I haven't reviewed this code, but I'll take your words on it.

On some level I kinda dislike the whole idea, but (a) I can certainly see its usefulness, and (b) as long as users are aware of the caveats involved (cut and paste was mentioned; also note that anything that is holding open a network connection will probably catch an RST on resume if suspended for too long) it's up to them whether to use it or not.

-- brandon s allbery kf8nh sine nomine associates allbery.b@gmail.com ballbery@sinenomine.net unix, openafs, kerberos, infrastructure, xmonad http://sinenomine.net

Brandon Allbery

10:03 a.m.

New subject: darcs patch: Add Stoppable layout for power saving (and 1 more)

On Sat, Sep 27, 2014 at 2:51 AM, Devin Mullins wrote:

...

Then I'm happy with it. From a quick glance, it appears so. The advice in $usage to do `layoutHook def ||| stoppable (layoutHook def)` (thereby doubling your list of layouts?) seems a bit weird, but maybe I'm misunderstanding it. Applied.

While it might be nice to use one of the layout toggles, most of those are painful enough that even I go to some lengths to avoid them. (Ever looked at the MultiToggle machinery?) -- brandon s allbery kf8nh sine nomine associates allbery.b@gmail.com ballbery@sinenomine.net unix, openafs, kerberos, infrastructure, xmonad http://sinenomine.net

Devin Mullins

2:32 p.m.

New subject: darcs patch: Add Stoppable layout for power saving (and 1 more)

Ah, no I haven't. HList, I see. I'll have to take a look at some point. On Sat, Sep 27, 2014 at 7:03 AM, Brandon Allbery wrote:

...

On Sat, Sep 27, 2014 at 2:51 AM, Devin Mullins wrote:

...
Then I'm happy with it. From a quick glance, it appears so. The advice in $usage to do `layoutHook def ||| stoppable (layoutHook def)` (thereby doubling your list of layouts?) seems a bit weird, but maybe I'm misunderstanding it. Applied.

While it might be nice to use one of the layout toggles, most of those are painful enough that even I go to some lengths to avoid them. (Ever looked at the MultiToggle machinery?)

-- brandon s allbery kf8nh sine nomine associates allbery.b@gmail.com ballbery@sinenomine.net unix, openafs, kerberos, infrastructure, xmonad http://sinenomine.net

4011

Age (days ago)

4015

Last active (days ago)

List overview

Download

5 comments

3 participants

participants (3)

Anton Vorontsov
Brandon Allbery
Devin Mullins