I have quite a few emails in my xmonad box, going back almost a year, containing patches with no follow-up emails. It's quite likely that many of these were superseded by other patches, decided against in a separate thread, or the like. However, it also seems quite likely that some of them fell through the cracks. If you know of any unapplied patches -- either ones that you submitted, or ones that you know of and would really like to be applied -- please re-send them to the list (making sure that there are no conflicts with the most recent darcs). I have some time at the moment, so I can take a look. -Brent
Hi, Am Freitag, den 02.01.2009, 13:11 -0500 schrieb Brent Yorgey:
I have quite a few emails in my xmonad box, going back almost a year, containing patches with no follow-up emails. It's quite likely that many of these were superseded by other patches, decided against in a separate thread, or the like. However, it also seems quite likely that some of them fell through the cracks. If you know of any unapplied patches -- either ones that you submitted, or ones that you know of and would really like to be applied -- please re-send them to the list (making sure that there are no conflicts with the most recent darcs). I have some time at the moment, so I can take a look.
http://darcswatch.nomeata.de/repo_http:__code.haskell.org_xmonad.html has ~15 unapplied patches. Two of these are mine, and improves multi-screen-stuff with focusFollowsMouse. They are improvements to Spencer’s patches back then. ATM, I’m not having a multi-screen-setup any more, so I can’t test if they are still applicable. http://darcswatch.nomeata.de/repo_http:__code.haskell.org_XMonadContrib.html has ~18 unapplied patches. Two of mine, and correspond to the patches mentioned above. If someone with a dual-screen setup wants to test them, that would be great. If you want to mark a patch as obsolete (because there is a better one submitted) or rejected (because it will not be accepted), use GET http://darcswatch.nomeata.de/....dpatch | mail -s '[OBSOLETE]' darcswatch@nomeata.de or GET http://darcswatch.nomeata.de/....dpatch | mail -s '[OBSOLETE]' darcswatch@nomeata.de where the URL is from the “Download .patch”-link below a patch. Greetings, Joachim -- Joachim "nomeata" Breitner mail: mail@joachim-breitner.de | ICQ# 74513189 | GPG-Key: 4743206C JID: nomeata@joachim-breitner.de | http://www.joachim-breitner.de/ Debian Developer: nomeata@debian.org
Great, thanks! I will try to take a look at these soon. Others with commit access should feel free to look at them too, I'm sure I will not be able to adequately judge the quality of all of them. I can, however, take a look at the dual-screen ones in the next week or so once I get back in to school, if no one else looks at them before then. -Brent
On Fri, Jan 02, 2009 at 07:29:31PM +0100, Joachim Breitner wrote:
http://darcswatch.nomeata.de/repo_http:__code.haskell.org_xmonad.html has ~15 unapplied patches.
Two of these are mine, and improves multi-screen-stuff with focusFollowsMouse. They are improvements to Spencer’s patches back then. ATM, I’m not having a multi-screen-setup any more, so I can’t test if they are still applicable.
I ended up writing alternative versions of those patches, so they should be marked obsolete.
http://darcswatch.nomeata.de/repo_http:__code.haskell.org_XMonadContrib.html has ~18 unapplied patches.
Two of mine, and correspond to the patches mentioned above.
If someone with a dual-screen setup wants to test them, that would be great.
Yes, someone please test those patches and advise whether they still apply to the current situation. Also, note that you can emulate multi-screen with the LayoutScreens contrib.
If you want to mark a patch as obsolete (because there is a better one submitted) or rejected (because it will not be accepted), use GET http://darcswatch.nomeata.de/....dpatch | mail -s '[OBSOLETE]' darcswatch@nomeata.de or GET http://darcswatch.nomeata.de/....dpatch | mail -s '[OBSOLETE]' darcswatch@nomeata.de where the URL is from the “Download .patch”-link below a patch.
Should this say '[REJECTED]'? Cheers, Spencer Janssen
Hi, Am Freitag, den 02.01.2009, 15:21 -0600 schrieb Spencer Janssen:
On Fri, Jan 02, 2009 at 07:29:31PM +0100, Joachim Breitner wrote:
http://darcswatch.nomeata.de/repo_http:__code.haskell.org_xmonad.html has ~15 unapplied patches.
Two of these are mine, and improves multi-screen-stuff with focusFollowsMouse. They are improvements to Spencer’s patches back then. ATM, I’m not having a multi-screen-setup any more, so I can’t test if they are still applicable.
I ended up writing alternative versions of those patches, so they should be marked obsolete.
If I remember correctly, you created patches to replace some of mine (listed in the obsolete section), but I thought it wasn’t done yet and added these two patches, so I think these are still applicable. At least http://darcswatch.nomeata.de/20081008164506-23c07-e8a65b4ccaf2b98d8d45c63011... lists your patches from 20081007 as dependencies. But as I said, I can’t test them properly, so you can forget about them unless someone has a look or I have a two-monitor setup again :-)
If you want to mark a patch as obsolete (because there is a better one submitted) or rejected (because it will not be accepted), use GET http://darcswatch.nomeata.de/....dpatch | mail -s '[OBSOLETE]' darcswatch@nomeata.de or GET http://darcswatch.nomeata.de/....dpatch | mail -s '[OBSOLETE]' darcswatch@nomeata.de where the URL is from the “Download .patch”-link below a patch.
Should this say '[REJECTED]'?
Right, thanks. Greetings, Joachim -- Joachim "nomeata" Breitner Debian Developer nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata
On Fri, Jan 2, 2009 at 1:11 PM, Brent Yorgey <byorgey@seas.upenn.edu> wrote:
I have quite a few emails in my xmonad box, going back almost a year, containing patches with no follow-up emails. It's quite likely that many of these were superseded by other patches, decided against in a separate thread, or the like. However, it also seems quite likely that some of them fell through the cracks. If you know of any unapplied patches -- either ones that you submitted, or ones that you know of and would really like to be applied -- please re-send them to the list (making sure that there are no conflicts with the most recent darcs). I have some time at the moment, so I can take a look.
-Brent
Where do we stand currently? I see 22 outstanding for XMC alone right now. * 20080521122822: Adding XMonad.Config.Xfce by Ivan.Miljenovic@gmail.com ** Obviously obsolete, since Config.Xfce has been there for a while now. * 20080602205742: XMonad.Actions.CopyWindow runOrCopy by lan3ny@gmail.com ** Looking back, I see I rubbished it for not being perfect (and not for any actual bug). Since no improvement has shown up in all that time, I've applied & pushed it. * 20080608222350: Make prompt controlMask keybindings work when other modifiers are active by Justin Bogner <mail@justinbogner.com> ** Dunno. I've asked bogner to bring this up again. * 20080626200455: ManageDocks: keep struts on top by Justin Bogner <mail@justinbogner.com> ** I've asked darcswatch to mark this obsolete, since according to http://code.google.com/p/xmonad/issues/detail?id=168 it is just experimental/proof-of-concept. * 20080710220410: XMonad.Actions.DynamicKeys: utilities to update key bindings at runtime by Marco Túlio Gontijo e Silva <marcot@riseup.net> ** I see no comments on this patch, and I don't see anything *obviously* wrong with it besides a missing definition. I've commented on the submission. * 20080714153248: XMonad.Config.Gnome: using XMonad.Actions.Plane by Marco Túlio Gontijo e Silva <marcot@riseup.net> ** The other patches in the bundle were applied, but not this one. Dunno why. See other thread - probably Spencer rejected it? * 20080926205838: dzenStatusBar by seanmce33@gmail.com, 20081002131304: layoutLogger, windowLogger, workspaceLogger,maildDir loggers by seanmce33@gmail.com ** byorgey tried to apply them, but failed. So we're blocked on sean re-sending them. * 20081007080041: UpdatePointer even to empty workspaces by Joachim Breitner <mail@joachim-breitner.de>, 20081008154245: pointWithin has moved to the core by Joachim Breitner <mail@joachim-breitner.de> ** Maintainer hasn't weighed in. Emailed in separate thread. * 20081012094402: FocusNth improvements. by Aleksey Artamonov <aleksey.artamonov@gmail.com> ** Obsoleted by Aleksey's second patch. I've mailed Darcswatch. * 20081019140330: FocusNth improvements fixed by Aleksey Artamonov <aleksey.artamonov@gmail.com> ** Blocked on maintainer. Separate thread. * 20081102045109: Actions.DisplayUI, for displaying bindings onscreen during screencasts by Wirt Wolff <wirtwolff@gmail.com> ** Wirt decided to recreate this patch after the keybinding facility is rewritten. I've mailed Darcswatch. * 20081212121339: ManageHelpers: Added isDialog by johanngiwer@web.de ** This is the original, which conflicted. Johann wrote it with a different title, and that got applied - but the different title meant that Darcswatch didn't pick it up. Emailed Darcswatch. * 20090102211626: Support for X actions in logHook by asgaroth <asgaroth_@gmx.de> ** byorgey seemed to reject this. Emailed Darcswatch. * 20090112185705: Adjustments to use the new event hook feature instead of Hooks.EventHook by Daniel Schoepe <asgaroth_@gmx.de> ** Same as DisplayUI - Daniel rewrote it. Emailed Darcswtach. * 20090117164445: Properly encode destop names before sending them to X server in XMonad.Hoo= by ks.EwmhDesktops Khudyakov Alexey <alexey.skladnoy@gmail.com> ** Blocked on our slow-moving UTF discussion. * 20090124010608: A mosaic layout based on MosaicAlt by Adam Vogt <vogt.adam@gmail.com> ** Another rewrite, another email. And finally, but not least: * 20090130114847: Multimedia keys support for EZConfig=20 by Khudyakov Alexey <alexey.skladnoy@gmail.com> ** Blocked on maintainer. See other thread. Summary: Many of these were obsolete or rejected in some way. 1 or 2 are blocked on the submitter submitting a non-conflicting one or coming up with a better one. Several are blocked on the maintainer of the affected module giving permission or rejecting it. The last one depends on the outcome of the UTF discussion. -- gwern
participants (5)
-
Brent Yorgey -
Gwern Branwen -
Joachim Breitner -
Joachim Breitner -
Spencer Janssen