Error compiling Commands.hs

A couple of minutes ago, I ran "darcs pull" for the main xmonad repo and for the contrib repo. Then I did "Setup.lhs clean", followed by "Setup.lhs configure ...", followed by "Setup.lhs build". The build fails with this error: | [11 of 13] Compiling XMonadContrib.Commands ( XMonadContrib/Commands.hs, | dist/build/xmonad/xmonad-tmp/XMonadContrib/Commands.o ) | | XMonadContrib/Commands.hs:69:73: | Couldn't match expected type `Maybe WorkspaceId' | against inferred type `WorkspaceId' | Expected type: Maybe WorkspaceId -> X () | Inferred type: WorkspaceId -> X () | In the second argument of `(>>=)', namely `f' | In the expression: (screenWorkspace (fromIntegral sc)) >>= f | make: *** [build] Error 1 Is it just me? Kai

On 7/16/07, Kai Grossjohann
A couple of minutes ago, I ran "darcs pull" for the main xmonad repo and for the contrib repo. Then I did "Setup.lhs clean", followed by "Setup.lhs configure ...", followed by "Setup.lhs build".
I'm the original author of Commands, but I have fallen into the pit of thesis and haven't updated my xmonad in weeks. Feel free to fix whatever is broken. --dave -- David Glasser | glasser@mit.edu | http://www.davidglasser.net/

On Mon, Jul 16, 2007 at 11:11:25AM -0400, David Glasser wrote:
On 7/16/07, Kai Grossjohann
wrote: A couple of minutes ago, I ran "darcs pull" for the main xmonad repo and for the contrib repo. Then I did "Setup.lhs clean", followed by "Setup.lhs configure ...", followed by "Setup.lhs build".
I'm the original author of Commands, but I have fallen into the pit of thesis and haven't updated my xmonad in weeks. Feel free to fix whatever is broken.
I wish I could fix it :-| I am very sorry to say that I don't grok Haskell. I read Hal Daume's tutorial, but I don't understand it. Kai

On Monday 16 July 2007 10:02:52 Kai Grossjohann wrote:
A couple of minutes ago, I ran "darcs pull" for the main xmonad repo and for the contrib repo. Then I did "Setup.lhs clean", followed by "Setup.lhs configure ...", followed by "Setup.lhs build".
The build fails with this error: | [11 of 13] Compiling XMonadContrib.Commands ( XMonadContrib/Commands.hs, | dist/build/xmonad/xmonad-tmp/XMonadContrib/Commands.o ) | | XMonadContrib/Commands.hs:69:73: | Couldn't match expected type `Maybe WorkspaceId' | against inferred type `WorkspaceId' | Expected type: Maybe WorkspaceId -> X () | Inferred type: WorkspaceId -> X () | In the second argument of `(>>=)', namely `f' | In the expression: (screenWorkspace (fromIntegral sc)) >>= f | make: *** [build] Error 1
Is it just me?
Kai
Andrea sent in a fix (just applied). We didn't catch this bug because Commands isn't in MetaModule. Commands isn't in MetaModule because it requires modifications to Config.hs (and Config.hs-boot) to compile. I'd appreciate it if somebody would take a look at that -- perhaps defaultCommands should be parametric on the command list, rather than importing the list from Config.hs? Cheers, Spencer Janssen

On Mon, Jul 16, 2007 at 12:05:49PM -0500, Spencer Janssen wrote:
We didn't catch this bug because Commands isn't in MetaModule. Commands isn't in MetaModule because it requires modifications to Config.hs (and Config.hs-boot) to compile. I'd appreciate it if somebody would take a look at that -- perhaps defaultCommands should be parametric on the command list, rather than importing the list from Config.hs?
actually I don't see any reason of Config.commands. Configuration can be achieved in some other way, if needed. since the author has no time, I'll send a patch to fix that. but if someone else wants the job fine. ciao andre
participants (4)
-
Andrea Rossato
-
David Glasser
-
Kai Grossjohann
-
Spencer Janssen