Infelicitous name choice in XPrompt.hs clashes with Config.hs
So I ran into a name-conflict with XPrompt.hs. The issue basically is that a function borderWidth is already defined in Config.hs. Thus, if one attempted to use a prompt configuration different than defaultXPConfig, and one defined it in one's Config.hs where it should be, then the borderWidth field would cause a warning by -Wall, since borderWidth is already a name being used by XMonad at large. -- gwern RUOP sh Al-Qaeda DOE SecDef owhere Gorelick military HoHoCon Stanley
On Tue, Sep 18, 2007 at 12:37:11PM -0400, Gwern Branwen wrote:
So I ran into a name-conflict with XPrompt.hs. The issue basically is that a function borderWidth is already defined in Config.hs. Thus, if one attempted to use a prompt configuration different than defaultXPConfig, and one defined it in one's Config.hs where it should be, then the borderWidth field would cause a warning by -Wall, since borderWidth is already a name being used by XMonad at large.
+ , borderPixel :: Dimension -- ^ Border width
Hi Gwern, the title of this message is definitely correct. But I'm not sure about the new field name: as far as my English goes, not that far actually, Pixel, in the Xlib library, refers to colors and depth, not to dimensions (think about blackPixel). While I think that with need a better name, can you confirm me that this is the right one? Thanks for
On Tue, Sep 18, 2007 at 09:05:12PM +0200, Andrea Rossato wrote:
On Tue, Sep 18, 2007 at 12:37:11PM -0400, Gwern Branwen wrote:
+ , borderPixel :: Dimension -- ^ Border width
Hi Gwern,
the title of this message is definitely correct. But I'm not sure about the new field name: as far as my English goes, not that far actually, Pixel, in the Xlib library, refers to colors and depth, not to dimensions (think about blackPixel). While I think that with need a better name, can you confirm me that this is the right one?
Might something like promptBorderWidth be appropriate? -- David Roundy Department of Physics Oregon State University
On Tue, Sep 18, 2007 at 09:05:12PM +0200, Andrea Rossato wrote:
On Tue, Sep 18, 2007 at 12:37:11PM -0400, Gwern Branwen wrote:
+ , borderPixel :: Dimension -- ^ Border width
the title of this message is definitely correct. But I'm not sure about the new field name: as far as my English goes, not that far actually, Pixel, in the Xlib library, refers to colors and depth, not to dimensions (think about blackPixel). While I think that with need a better name, can you confirm me that this is the right one?
nBorderPixels, borderPixels Kai
On Tuesday 18 September 2007 11:37:11 Gwern Branwen wrote:
So I ran into a name-conflict with XPrompt.hs. The issue basically is that a function borderWidth is already defined in Config.hs. Thus, if one attempted to use a prompt configuration different than defaultXPConfig, and one defined it in one's Config.hs where it should be, then the borderWidth field would cause a warning by -Wall, since borderWidth is already a name being used by XMonad at large.
-- gwern RUOP sh Al-Qaeda DOE SecDef owhere Gorelick military HoHoCon Stanley
There were some concerns about this name change. I've decided to apply this patch for now, because the conflict with borderWidth is more serious. We can always change the name later. Cheers, Spencer Janssen
participants (5)
-
Andrea Rossato -
David Roundy -
Gwern Branwen -
Kai Grossjohann -
Spencer Janssen