Possible borkage in patch for EwmhDesktops, ManageDocks and SetWMName
The patch I posted yesterday to fix building of EwmhDesktops, ManageDocks and SetWMName for amd64 may have introduced regressions. I suspect this because EwmhDesktops or SetWMName has been causing my gnome-panel to crash fairly frequently, including every time I exit Gimp. Joachim, can you please review the whole patch? (You can safely ignore the whitespace fixes. ;) ) -- Alex Tarkovsky
Hi, Am Donnerstag, den 11.10.2007, 02:05 -0500 schrieb Alex Tarkovsky:
The patch I posted yesterday to fix building of EwmhDesktops, ManageDocks and SetWMName for amd64 may have introduced regressions. I suspect this because EwmhDesktops or SetWMName has been causing my gnome-panel to crash fairly frequently, including every time I exit Gimp.
Joachim, can you please review the whole patch? (You can safely ignore the whitespace fixes. ;) )
The patch looks good (you have just added some “fromIntegral”, right?), not sure what they might break. Also, I don’t have an AMD64... Anyways, I have not heard from anyone else but me that these modules actually work, so maybe there is not regression and it was broken for anyone else but me before. Greetings, Joachim -- Joachim Breitner e-Mail: mail@joachim-breitner.de Homepage: http://www.joachim-breitner.de ICQ#: 74513189
Il Thu, Oct 11, 2007 at 11:47:22AM +0200, Joachim Breitner ebbe a scrivere:
Anyways, I have not heard from anyone else but me that these modules actually work, so maybe there is not regression and it was broken for anyone else but me before.
I tried ManageDocks and I can confirm it was working perfectly here. I didn't have time to test this patch yet and I'll do as soon as I can. Andrea
On Thursday 11 October 2007 02:05:20 Alex Tarkovsky wrote:
The patch I posted yesterday to fix building of EwmhDesktops, ManageDocks and SetWMName for amd64 may have introduced regressions. I suspect this because EwmhDesktops or SetWMName has been causing my gnome-panel to crash fairly frequently, including every time I exit Gimp.
Joachim, can you please review the whole patch? (You can safely ignore the whitespace fixes. ;) )
These modules worked fine on my system both before and after the patch, so I don't think you've introduced a regression. Cheers, Spencer Janssen
participants (4)
-
Alex Tarkovsky -
Andrea Rossato -
Joachim Breitner -
Spencer Janssen