darcs patch: Let the user decide which commands to use in X.H.Serve...

Tue Aug 25 12:16:30 CEST 2009 Daniel Schoepe

* On Tuesday, August 25 2009, Daniel Schoepe wrote:
Tue Aug 25 12:16:30 CEST 2009 Daniel Schoepe
* Let the user decide which commands to use in X.H.ServerMode
2 configs in the config archive use ServerMode, so I think backwards compatibility takes precedence over the cluttering the API here, but perhaps not by much... So, I've pushed this and another patch that keeps the old type signature for serverModeEventHook, and puts the new function in serverModeEventHook'. Thanks. -- Adam

On Tue, Aug 25, 2009 at 06:19:17PM -0400, Adam Vogt wrote:
* On Tuesday, August 25 2009, Daniel Schoepe wrote:
Tue Aug 25 12:16:30 CEST 2009 Daniel Schoepe
* Let the user decide which commands to use in X.H.ServerMode 2 configs in the config archive use ServerMode, so I think backwards compatibility takes precedence over the cluttering the API here, but perhaps not by much...
So, I've pushed this and another patch that keeps the old type signature for serverModeEventHook, and puts the new function in serverModeEventHook'.
I believe the patch in this form does not work correctly. Look at the call to runCommand' - it's defined in XMonad.Actions.Commands and looks up the command in defaultCommands. So you always run the default commands right now, no matter what list you select them from. The attached, simple patch should solve this (I'm not sure why runCommand' was used in the first place). It's untested, but I extended ServerMode in a similar way a while ago in my Bluetile repository. Regards! Jan
participants (3)
-
Adam Vogt
-
Daniel Schoepe
-
Jan Vornberger