Adding side tabs to XMonad.Layout.Tabbed

newer
insertPosition and floating windows

older
Patch proposal: Save arbitary data...

Arjun Comar

13 Feb 2014 13 Feb '14

5:03 p.m.

Hi all, Attached is a patch that adds side tabs to XMonad.Layout.Tabbed. It's a relatively simple change and I've added documentation for the newly added functions, keeping the same format as the equivalent functions already present in the file. Thanks, Arjun

Attachments:

attachment.html (text/html — 308 bytes)
sidetabs.patch (text/x-patch — 19.1 KB)

Show replies by date

Daniel Wagner

17 Feb 17 Feb

3:50 p.m.

Hi Arjun -- Looks like a nice patch, thanks! From my glance through the code, it doesn't look like existing configs should break, but you're closer to the code, so maybe you can make a comment and reassure me that this is the case. The names LeftS and RightS are a bit strange -- is there a reason they're not just Left and Right? Since they seem to be entirely internal, it's not so critical that we get the names right here, but I am a bit curious. I haven't heard any other complaints, and as far as I'm concerned, of the two mentioned here only back-compat would be a compelling reason not to apply the patch. So if I hear back about that, and nobody else complains in the next few days, I'll apply your patch. ~d On 2014-02-13 17:03, Arjun Comar wrote:

...

Hi all, Attached is a patch that adds side tabs to XMonad.Layout.Tabbed. It's a relatively simple change and I've added documentation for the newly added functions, keeping the same format as the equivalent functions already present in the file.

Thanks, Arjun

_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad

adam vogt

4:16 p.m.

Hi Daniel and Arjun, LeftS and RightS don't take arguments like Left and Right do. TabbarLocation could be defined in terms of http://xmonad.org/xmonad-docs/xmonad-contrib/XMonad-Util-Types.html#t:Direct..., but it's fine as-is too. -- Adam

Arjun Comar

6:32 p.m.

Hi Daniel, I can confirm that existing configs shouldn't break unless the user has behavior that operates on TabbarLocation (which seems weird, that kind of stuff really belongs in XMonad.Layout.Tabbed). If they *do* have that kind of behavior, they'll need to update their pattern matching to handle the LeftS/RightS cases. The naming is weird, but it's to prevent conflicts with Either. I was going for a Leftside/Rightside mnemonic. I actually like Adam's idea of just using Direction2D. That should also not break user configs since the interface functions don't ask for Top/Bottom/etc. and instead have separate functions for each task. Thanks, Arjun On Mon, Feb 17, 2014 at 4:16 PM, adam vogt wrote:

...

Hi Daniel and Arjun,

LeftS and RightS don't take arguments like Left and Right do. TabbarLocation could be defined in terms of

http://xmonad.org/xmonad-docs/xmonad-contrib/XMonad-Util-Types.html#t:Direct... , but it's fine as-is too.

-- Adam _______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad

Arjun Comar

19 Feb 19 Feb

3:12 p.m.

Hi all, Here's an updated patch that switches TabbarLocation with Direction2D. Thanks, Arjun On Mon, Feb 17, 2014 at 6:32 PM, Arjun Comar wrote:

...

Hi Daniel, I can confirm that existing configs shouldn't break unless the user has behavior that operates on TabbarLocation (which seems weird, that kind of stuff really belongs in XMonad.Layout.Tabbed). If they *do* have that kind of behavior, they'll need to update their pattern matching to handle the LeftS/RightS cases.

The naming is weird, but it's to prevent conflicts with Either. I was going for a Leftside/Rightside mnemonic. I actually like Adam's idea of just using Direction2D. That should also not break user configs since the interface functions don't ask for Top/Bottom/etc. and instead have separate functions for each task.

Thanks, Arjun

On Mon, Feb 17, 2014 at 4:16 PM, adam vogt wrote:

...
Hi Daniel and Arjun,

LeftS and RightS don't take arguments like Left and Right do. TabbarLocation could be defined in terms of

http://xmonad.org/xmonad-docs/xmonad-contrib/XMonad-Util-Types.html#t:Direct... , but it's fine as-is too.

-- Adam _______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad

Arjun Comar

10 Mar 10 Mar

4:55 p.m.

Hi all, Just wanted to check and see if there were any further issues with this patch. Thanks, Arjun On Wed, Feb 19, 2014 at 3:12 PM, Arjun Comar wrote:

...

Hi all, Here's an updated patch that switches TabbarLocation with Direction2D.

Thanks, Arjun

On Mon, Feb 17, 2014 at 6:32 PM, Arjun Comar wrote:

...
Hi Daniel, I can confirm that existing configs shouldn't break unless the user has behavior that operates on TabbarLocation (which seems weird, that kind of stuff really belongs in XMonad.Layout.Tabbed). If they *do* have that kind of behavior, they'll need to update their pattern matching to handle the LeftS/RightS cases.

The naming is weird, but it's to prevent conflicts with Either. I was going for a Leftside/Rightside mnemonic. I actually like Adam's idea of just using Direction2D. That should also not break user configs since the interface functions don't ask for Top/Bottom/etc. and instead have separate functions for each task.

Thanks, Arjun

On Mon, Feb 17, 2014 at 4:16 PM, adam vogt wrote:

...
Hi Daniel and Arjun,

LeftS and RightS don't take arguments like Left and Right do. TabbarLocation could be defined in terms of

http://xmonad.org/xmonad-docs/xmonad-contrib/XMonad-Util-Types.html#t:Direct... , but it's fine as-is too.

-- Adam _______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad

Daniel Wagner

16 Mar 16 Mar

3:04 p.m.

Hi Arjun -- it's applied, thanks for the patch and followup! ~d On 2014-03-10 16:55, Arjun Comar wrote:

...

Hi all, Just wanted to check and see if there were any further issues with this patch.

Thanks, Arjun

On Wed, Feb 19, 2014 at 3:12 PM, Arjun Comar wrote:

...
Hi all, Here's an updated patch that switches TabbarLocation with Direction2D.

Thanks, Arjun

On Mon, Feb 17, 2014 at 6:32 PM, Arjun Comar wrote:

Hi Daniel, I can confirm that existing configs shouldn't break unless the user has behavior that operates on TabbarLocation (which seems weird, that kind of stuff really belongs in XMonad.Layout.Tabbed). If they *do* have that kind of behavior, they'll need to update their pattern matching to handle the LeftS/RightS cases.

The naming is weird, but it's to prevent conflicts with Either. I was going for a Leftside/Rightside mnemonic. I actually like Adam's idea of just using Direction2D. That should also not break user configs since the interface functions don't ask for Top/Bottom/etc. and instead have separate functions for each task.

Thanks, Arjun

On Mon, Feb 17, 2014 at 4:16 PM, adam vogt wrote: Hi Daniel and Arjun,

LeftS and RightS don't take arguments like Left and Right do. TabbarLocation could be defined in terms of

http://xmonad.org/xmonad-docs/xmonad-contrib/XMonad-Util-Types.html#t:Direct...

...
[1], but it's fine as-is too.

-- Adam

_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad [2]

Links: ------ [1] http://xmonad.org/xmonad-docs/xmonad-contrib/XMonad-Util-Types.html#t:Direct... [2] http://www.haskell.org/mailman/listinfo/xmonad

4083

Age (days ago)

4114

Last active (days ago)

List overview

Download

6 comments

3 participants

participants (3)

adam vogt
Arjun Comar
Daniel Wagner