On Tue, Nov 20, 2007 at 07:01:19AM -0800, David Roundy wrote:

On Mon, Nov 19, 2007 at 09:54:06PM -0500, Brent Yorgey wrote:

...

As seen on xmonad@! A module which allows you to configure layouts per-workspace. Testing, comments, criticisms, edits, etc. welcome.

I'd also add that I think it'd be handy to be able to give a list of WorkspaceId rather than just one, so we could say onWorkspaces ["web","email","irc"] mytabbed $ onWorkspaces ["darcs","xmonad"] (mytabbed <-//> mytabbed ||| mytabbed) $ Full That'd be a stupid set of layouts, but you can see the idea: most users will have two or three sets of layouts, max, and will want to divy them up among their workspaces. -- David Roundy Department of Physics Oregon State University

On Tue, Nov 20, 2007 at 11:07:50AM -0500, Brent Yorgey wrote:

...

I'd also add that I think it'd be handy to be able to give a list of WorkspaceId rather than just one, so we could say

onWorkspaces ["web","email","irc"] mytabbed $ onWorkspaces ["darcs","xmonad"] (mytabbed <-//> mytabbed ||| mytabbed) $ Full

That'd be a stupid set of layouts, but you can see the idea: most users will have two or three sets of layouts, max, and will want to divy them up among their workspaces.

I thought of this, but the problem is the types. What should the type of onWorkspaces be? If you try to write this function, you get an infinite type error. Unless there's some tricky type-hacking that can be done to get around it.

onWorkspaces onWorkspaces :: (LayoutClass l1 a, LayoutClass l2 a) => [WorkspaceId] -- ^ the tag of workspaces to match -> (l1 a) -- ^ layout to use on the matched workspace -> (l2 a) -- ^ layout to use everywhere else -> PerWorkspace l1 l2 a data PerWorkspace l1 l2 a = PerWorkspace [WorkspaceId] (Maybe Bool) (l1 a) (l2 a) deriving (Read, Show) I think that's the key: moving the functionality into the data type. -- David Roundy Department of Physics Oregon State University

On Nov 20, 2007 10:01 AM, David Roundy wrote:

On Mon, Nov 19, 2007 at 09:54:06PM -0500, Brent Yorgey wrote:

...

As seen on xmonad@! A module which allows you to configure layouts per-workspace. Testing, comments, criticisms, edits, etc. welcome.

This is buggy when multiple screens are in use, because of the following code:

-- figure out which layout to use based on the current workspace. doLayout (PerWorkspace wsId Nothing l1 l2) r s = do t <- getCurrentTag doLayout (PerWorkspace wsId (Just $ wsId == t) l1 l2) r s

There's no guarantee that the *current* screen is the one that's having doLayout called. :(

We also have trouble with:

handleMessage (PerWorkspace wsId Nothing l1 l2) m = do t <- getCurrentTag handleMessage (PerWorkspace wsId (Just $ wsId == t) l1 l2) m

because the message might have been sent using broadcastMessage rather than sendMessage, so we again might not be the main workspace.

David, thanks for the bug reports. I don't have multiple screens so I didn't even think about that problem... oops! Unfortunately, I don't have a lot of time right now, so for the moment I think I will just change the code to ignore messages received before doLayout gets called, and add a note to say that it doesn't (yet) work in conjunction with multiple screens. If someone wants to try fixing it in a more general way, be my guest. -Brent