Hello, I really like these changes. The gs_navigate changes don't make it easy to add or remove keys without duplicating the existing 'bindings'. Perhaps it might be better to hide the continuation in GridSelect code: the set up could be more like xmonad's with various modes done like Submap. Maybe I've misunderstood the flexiblity of how it's done with gs_navigate in the path. Just exporting the list of bindings probably makes more sense though. I've pushed all patches anyways: gs_navigate is reasonable, and even if it does get changed again, I doubt many people will be affected. Adam * On Tuesday, November 02 2010, Clemens Fruhwirth wrote:

8 patches for repository http://code.haskell.org/XMonadContrib:

Sat Oct 16 18:41:51 CEST 2010 Clemens Fruhwirth * Make use of field names when constructing TwoDState in X.A.GridSelect

Sat Oct 16 18:47:57 CEST 2010 Clemens Fruhwirth * Convert access of td_elementmap from field styled to function call styled in X.A.GridSelect

Sat Oct 16 20:31:32 CEST 2010 Clemens Fruhwirth * Remove nub from diamondLayer in X.A.GridSelect

Sat Oct 16 20:35:54 CEST 2010 Clemens Fruhwirth * Refactor for ad-hoc element and position matching turning td_elementmap into a function using the new td_availSlot and td_elements fields

Sat Oct 16 20:36:44 CEST 2010 Clemens Fruhwirth * Add substring filter to td_elementmap

Sat Oct 16 23:25:59 CEST 2010 Clemens Fruhwirth * Introduce grayoutAllElements in X.A.GridSelect

Sat Oct 16 23:29:04 CEST 2010 Clemens Fruhwirth * Make substring search case insensitive

Tue Nov 2 22:12:13 CET 2010 Clemens Fruhwirth * Substring search support for X.A.GridSelect. As keymaps get more complicated to support different styles, the gs_navigate element is fundamentially changed.

_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad