darcs patch: ungrab-keyboard-before-action
In X.A.Submap, the keyboard is grabbed to handle the submapping. However, the keyboard is not released until *after* the action is executed. This creates the situation where any action which requires a keyboard grab (such as submap itself), cannot be submapped. I encountered this issue with WindowBringer where dmenu would fail to appear since it failed to grab the keyboard. A delay could be used, but this is just a race. Testing is probably needed; I've seen no issues so far and I'm a heavy user of submap (my modMask is essentially <Ctrl-i>). --Ben [1]http://git.benboeckel.net/?p=dotfiles.git;a=blob;f=dotfiles/base/X11/xmonad/... 1 patch for repository http://code.haskell.org/XMonadContrib: Sun May 15 17:03:12 EDT 2011 Ben Boeckel <mathstuf@gmail.com> * ungrab-keyboard-before-action If an action that requires the keyboard to be grabbed (e.g., launching dmenu), it is a race when submapping the action as to whether the action will have access to the keyboard or not. To fix this, the keyboard should be ungrabbed before executing the action.
This 1-patch bundle was just applied to http://code.haskell.org/XMonadContrib: 20110515210312 Ben Boeckel <mathstuf@gmail.com> * ungrab-keyboard-before-action If an action that requires the keyboard to be grabbed (e.g., launching dmenu), it is a race when submapping the action as to whether the action will have access to the keyboard or not. To fix this, the keyboard should be ungrabbed before executing the action. -- This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__code.haskell.org_XMonadContrib.html...
participants (2)
-
Ben Boeckel -
darcswatch@nomeata.de