darcs patch: handle-windows-with-no-sizehint

1 patch for repository http://code.haskell.org/xmonad:
Fri Mar 9 01:23:43 EST 2012 Ben Boeckel

Haskell package janitor in charge of X11 here. If you formulate this
as a patch to X11, I'll happily apply it.
Can't apply this one though -- I don't have commit access to xmonad-core.
~d
Quoting Ben Boeckel
1 patch for repository http://code.haskell.org/xmonad:
Fri Mar 9 01:23:43 EST 2012 Ben Boeckel
* handle-windows-with-no-sizehint When a window has no size hint set, the memory returned by XGetWMNormalHints may be pretty useless. This can cause hint-less windows to bounce between 1x1, 1xn, mx1, the proper size, and (rarely) fullscreen when the layoutHints layout modifier from xmonad-contrib is used.
Two programs that exhibit this behavior are feh and sxiv.

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On Fri, Mar 09, 2012 at 21:41:47 GMT, wagnerdm@seas.upenn.edu wrote:
Haskell package janitor in charge of X11 here. If you formulate this as a patch to X11, I'll happily apply it.
Can't apply this one though -- I don't have commit access to xmonad-core.
Pull request filed[1]. Thanks! - --Ben [1]https://github.com/haskell-pkg-janitors/X11/pull/5 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCgAGBQJPWrmLAAoJEKaxavVX4C1XG3EP/Ru6nfldpSF4VJzYJJ4nHRGU z8fUmWDA6QW7rm/EeSEtsoQ77QEKDbm34muMsuTh0IFmiO3fdKALBiHItUm83J8k ykR90uSpqa8DNmTSM0ns/BhxFyntTZadJoIkY2Z+83t1o+Ke6VMIHZncDQaq4jWC 35uFpxKN7KR8HLykpvhGXOvYQy9m+3jdSYc30HhufgUYLsH2lAh8gLJFeq+M3Nox K++jX3NJzlwwCPikWNuQLP7XGKoQ/VMtPw9I97Sv3Pjpj5Vw6LOwYf1EZhTo4BFm A0k8qxfKOYq2taaC/75jxkqkSL2vh7JjOt8TsAF+P/UVofA/Lw4HQGQSmt6mkRCZ uInfJHXJdyNfHb7yDBX4t4ebsQYapwfIqLuEGOO9mEzC6ivGBoV2U/emq8Lmm/R8 XGyxssupOQ2ZAOa53tF7nfW9q+J7nYCgAeZ1YMAdUi75XugglOMGIPchQYfU/NMW bH9pTTWLzh9Wt2CR2odNsA9o7yVkpbufmyfFymF/18u33BApT+k5ng7qR3Td0tcM OyI73WtGyDSAApFCpwP7oN3W8aKxtHI4nSczbX/Ot1O+OFgkveafovLV/pw2HglV T+ImxK7GCTloqM/Ou7RMDdN1GLNHm62tr1BG7/KKMYTyBqrM7PXMtU7TVP+wP0So 2QBqPL/vOhAgI1ewnqHI =IqDW -----END PGP SIGNATURE-----

After some IRC discussion, it seems the correct solution is to keep
X11's current API, but do more error-checking in the getWMNormalHints
function it exports. After this change to the X11 library, no changes
to the xmonad core or xmonad-contrib codebases should be necessary...
so please don't apply the other patches in this email thread!
(Ben, please correct me if I misunderstood our conversation.)
Those of you who wish to see use fixes now may clone the current X11
repository, which has this fix.
git clone git@github.com:haskell-pkg-janitors/X11.git
~d
Quoting Ben Boeckel
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
On Fri, Mar 09, 2012 at 21:41:47 GMT, wagnerdm@seas.upenn.edu wrote:
Haskell package janitor in charge of X11 here. If you formulate this as a patch to X11, I'll happily apply it.
Can't apply this one though -- I don't have commit access to xmonad-core.
Pull request filed[1]. Thanks!
- --Ben
[1]https://github.com/haskell-pkg-janitors/X11/pull/5
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCgAGBQJPWrmLAAoJEKaxavVX4C1XG3EP/Ru6nfldpSF4VJzYJJ4nHRGU z8fUmWDA6QW7rm/EeSEtsoQ77QEKDbm34muMsuTh0IFmiO3fdKALBiHItUm83J8k ykR90uSpqa8DNmTSM0ns/BhxFyntTZadJoIkY2Z+83t1o+Ke6VMIHZncDQaq4jWC 35uFpxKN7KR8HLykpvhGXOvYQy9m+3jdSYc30HhufgUYLsH2lAh8gLJFeq+M3Nox K++jX3NJzlwwCPikWNuQLP7XGKoQ/VMtPw9I97Sv3Pjpj5Vw6LOwYf1EZhTo4BFm A0k8qxfKOYq2taaC/75jxkqkSL2vh7JjOt8TsAF+P/UVofA/Lw4HQGQSmt6mkRCZ uInfJHXJdyNfHb7yDBX4t4ebsQYapwfIqLuEGOO9mEzC6ivGBoV2U/emq8Lmm/R8 XGyxssupOQ2ZAOa53tF7nfW9q+J7nYCgAeZ1YMAdUi75XugglOMGIPchQYfU/NMW bH9pTTWLzh9Wt2CR2odNsA9o7yVkpbufmyfFymF/18u33BApT+k5ng7qR3Td0tcM OyI73WtGyDSAApFCpwP7oN3W8aKxtHI4nSczbX/Ot1O+OFgkveafovLV/pw2HglV T+ImxK7GCTloqM/Ou7RMDdN1GLNHm62tr1BG7/KKMYTyBqrM7PXMtU7TVP+wP0So 2QBqPL/vOhAgI1ewnqHI =IqDW -----END PGP SIGNATURE-----
_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On Sat, Mar 10, 2012 at 08:19:11 GMT, wagnerdm@seas.upenn.edu wrote:
After some IRC discussion, it seems the correct solution is to keep X11's current API, but do more error-checking in the getWMNormalHints function it exports. After this change to the X11 library, no changes to the xmonad core or xmonad-contrib codebases should be necessary... so please don't apply the other patches in this email thread!
Agreed. These patches are unnecessary.
(Ben, please correct me if I misunderstood our conversation.)
Those of you who wish to see use fixes now may clone the current X11 repository, which has this fix.
git clone git@github.com:haskell-pkg-janitors/X11.git
I can verify that I have not seen the behavior with the new patch. - --Ben -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCgAGBQJPW4ucAAoJEKaxavVX4C1XUo8P/2vCdRvGq/AwTD0DE57Ba75Q Rb/wRjOMInXZsRqojUYLvpcabgkaTkJpxiabjEH6Z+dBzWsTM3AXzNR16wY0hfcP TgxnpZbNbKBcLnQ6PHriwVanR3MlAwuWQmVszIhFLLhEw0pAIYKFgd2ZDRdZkZ1O iZfvR/ijY5j0VLaRGC2moUWjVwPdmBmGr9aTlPBQPp92aA5dPQi5H7gejfS6XLEN PyyzY9gK3s3AMxTSMR8Cra27GOrKNrv7a28BJ/GBi7wKpTNhs8Bu2KdIcA/0nUyL 4mMGkfvhyxIWdLq0GIPU0umn/fVM2A5eeUhfN8PFrrW4x5i2//k0N3Inzd65F8Dl ZvWKu7h/fiJfla5XwYg8/k8ifo4m3VlCSXINEinA33qD3mZ2UOs4970zsG3QE4V6 vcJBFzMZowqU+3xNCjd4KIsdXjFDYhIHCds5TaTkKIaZL3KpJCIh5Wr2p9XsjVPy pCHj2ZH3lkpberlvE/WyOCRKokkLg9OBPRnBx9AYF74R03n89pUuvajfNgdPVkl2 hE4jCewBqu0VuWkKvecAV0sQb2F+wZK3/gwzVqyMECDK1CkPaVIrHd6/aes2VIu2 QVNC54a7dVJrRfE9B1ZizGBiC+txctwpeUqGHJYNklLzOspOLaScSrYl5JZCvqtx VQGnTQV7dcLgV0nIwd9x =sw3X -----END PGP SIGNATURE-----
participants (2)
-
Ben Boeckel
-
wagnerdm@seas.upenn.edu