
The last 3 are just config tweaks that I think are better. Pure opinion of course.
My config is configured more than this, but these are the ones that I think could be
candidates for defaulting.
The shift cleanup is basically switching the style from using lists as control
structures to explicit composition.
The Properties.hs patch is probably the most interesting. I'm not entirely sure it is
doing what it's supposed to, but the intent is to limit the range of certain random
numbers, such that reasonable ranges are tested. I think that at the moment pretty much
all the iterations on these particular tests succeed since the number is way out of
range. After fixing this for some, all the tests still work :) I'd suggest that
someone more familiar with xmonad look over the tests for these situations, though.
Hmm, I probably should have added those as long comments to the patches...
Sun Jul 22 13:52:25 PDT 2007 Michael G. Sloan

mgsloan:
The last 3 are just config tweaks that I think are better. Pure opinion of course. My config is configured more than this, but these are the ones that I think could be candidates for defaulting.
The shift cleanup is basically switching the style from using lists as control structures to explicit composition.
Can you resubmit just the properties change, and the new version of 'shift' please. Also, can you use debug=True for QuickCheck ,to confirm the range of values being produced, before and after your changes to the properties file. -- Don
participants (2)
-
dons@cse.unsw.edu.au
-
Michael G.Sloan