I have attached a patch - but I had to use darcs record --no-test as I was getting haddock errors from GridSelect (probably due to jaunty's haddock being old and busted). Sorry about that ... On Tue, Apr 28, 2009 at 2:40 PM, Don Stewart wrote:

rupa:

...

When trying to compile xmonad latest darcs under ghc 6.8.2dfsg1-1ubuntu1 (jaunty default) I got the following error:

XMonad/Layout/SubLayouts.hs:309:16: Illegal signature in pattern: LayoutMessages Use -XPatternSignatures to permit it

Apparently people using 6.10 do not get this error, which went away when I added PatternSignatures to the LANGUAGE pragmas of the modules as suggested in IRC.

Just a heads up, I'm not sure what, if anything, should be done here ...

Could you send a patch?

-- Don

Thanks, everything works fine now - much obliged. On Tue, Apr 28, 2009 at 7:13 PM, Adam Vogt wrote:

Your patch unfortunately causes warnings about -XPatternSignatures being depreciated when run with ghc-6.10.2

I've pushed a patch that eliminates the need for -XPatternSignatures or -XScopedTypeVariables in SubLayouts. I think that such changes are less unpleasant than using the CPP to hide pragmas from specific ghc versions.

Please confirm that a 'darcs pull' fixes the issue.

Thanks, Adam

* On Tuesday, April 28 2009, rupa wrote:

...

I have attached a patch - but I had to use darcs record --no-test as I was getting haddock errors from GridSelect (probably due to jaunty's haddock being old and busted). Sorry about that ...