On Wed, Jun 22, 2016 at 3:55 PM, Daniel Wagner wrote:

It is not conveniently possible to wrap `X` actions

userCode and userCodeDef, in XMonad.Core. -- brandon s allbery kf8nh sine nomine associates allbery.b@gmail.com ballbery@sinenomine.net unix, openafs, kerberos, infrastructure, xmonad http://sinenomine.net

I suppose the question that this error is asking you is: when `getWindowAttributes` throws an error, how should `floatLocation` respond? Perhaps returning some default -- like `(0, RationalRect 0 0 1 1)` or something -- will be sufficient? I don't know how `floatLocation` gets used, so I don't know how dangerous a default that would be. Do we need to change the type of `floatLocation` to admit that it may not know the right answer? ~d On Sat, Sep 10, 2016 at 3:09 PM, Adam Sjøgren wrote:

Daniel writes:

...

The simplest thing will be to wrap just the call to `getWindowAttributes`, if that's the one you expect to fail.

It is one I observe failing, yes.

...

It is not conveniently possible to wrap `X` actions; so instead, something like

withDisplay $ \d -> do ws <- gets windowset ewa <- io $ try (getWindowAttributes d w) case ewa of Left e -> io (putStrLn "HELP! do something!") Right wa -> do let bw = (fromIntegral . wa_border_width) wa {- ... etc. -}

I can't make this construction compile, when I try to change floatLocation to use it, I get errors about a return value being of type X () instead of X (ScreenId, W.RationalRect).

Best regards,

Adam

-- "Alla för alla, en för en Adam Sjøgren Alla för alla, en för en asjo@koldfront.dk Så börjar vi om igen"

_______________________________________________ xmonad mailing list xmonad@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad

Brandon writes:

On Sun, Sep 11, 2016 at 7:11 PM, Daniel Wagner wrote:

...

I suppose the question that this error is asking you is: when `getWindowAttributes` throws an error, how should `floatLocation` respond?

Yeah, and I don't really know enough to answer that question either. I guess something is really wrong with the window, and XMonad should give up?

I am not sure I understand wjy getWindowAttributes would throw an exception except for "window removed",

That could very well be it, I usually see the exceptions from getWindowAttributes in floatLocation when Gimp opens windows that display some kind of progress and quickly closes them again.

and for most of those you probably want to be aborting the hook in question. So, make sure it's always under control of userCode; this would include moving the one in X.O.manage into a userCode, but that would probably be smart anyway since I think we crash currently if the new window we want to manage goes away before we can. Or both its uses (one to manage initial windows at startup and one in response to MapRequestEvent).

Yes. Uhm. Ah. I haven't got the foggiest of how to do any of that. Best regards, Adam -- "Good evening. Today is Good Friday. There is no news." Adam Sjøgren asjo@koldfront.dk