2013-02-09 change to XMonad.Prompt.Shell breaks shell completion

The following change from 2013-02-09 breaks shell completion for me: hunk ./XMonad/Prompt/Shell.hs 65 + commandToComplete _ c = c It seems to be passing the entire string into compgen in order to get the file completions, but it should only pass the last word. I propose reverting this change. Comments are appreciated. (CCing c.lopez@kmels.net, who originally wrote the patch.)

Hi,
Thanks for investigating. Completions are better for my purposes with your
proposed change.
I am not sure what is different about Carlos López Camey and Carsten
Mattner's setups which made that patch "fix" things.
Adam
On Thu, Jan 30, 2014 at 3:04 PM, md143rbh7f
The following change from 2013-02-09 breaks shell completion for me: hunk ./XMonad/Prompt/Shell.hs 65 + commandToComplete _ c = c
It seems to be passing the entire string into compgen in order to get the file completions, but it should only pass the last word. I propose reverting this change. Comments are appreciated.
(CCing c.lopez@kmels.net, who originally wrote the patch.)
_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad

Hi,
After a bit of off-list discussion it looks like md143rbh7f's patch is
good. I've pushed it.
Adam
On Thu, Jan 30, 2014 at 9:12 PM, adam vogt
Hi,
Thanks for investigating. Completions are better for my purposes with your proposed change.
I am not sure what is different about Carlos López Camey and Carsten Mattner's setups which made that patch "fix" things.
Adam
On Thu, Jan 30, 2014 at 3:04 PM, md143rbh7f
wrote: The following change from 2013-02-09 breaks shell completion for me: hunk ./XMonad/Prompt/Shell.hs 65 + commandToComplete _ c = c
It seems to be passing the entire string into compgen in order to get the file completions, but it should only pass the last word. I propose reverting this change. Comments are appreciated.
(CCing c.lopez@kmels.net, who originally wrote the patch.)
_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad
participants (2)
-
adam vogt
-
md143rbh7f