darcs patch: Correctly handle resize requests (-12 +22)

Sun Jun 3 13:31:53 PDT 2007 Stefan O'Rear

On Sun, 03 Jun 2007 13:38:29 -0700
"Stefan O'Rear"
Sun Jun 3 13:31:53 PDT 2007 Stefan O'Rear
* Correctly handle resize requests (-12 +22) Xmonad now implements resize requests in a consistent manner. * If the window is FLOATING, we implement the program's request, and correctly update the StackSet; so it will keep the new size. This should work correctly even for non-current windows.
* Otherwise, we ignore the request. As per ICCCM, we send a fake ConfigureNotify containing the new (unchanged) geometry. This is perfectly ICCCM compliant, and if it breaks your client, it's your own fault.
This patch requires setConfigureEvent, which is added to X11-extras by a patch approximately contemporaneous with this one.
Applied, thanks.

Stefan O'Rear
Sun Jun 3 13:31:53 PDT 2007 Stefan O'Rear
* Correctly handle resize requests (-12 +22) Xmonad now implements resize requests in a consistent manner. * If the window is FLOATING, we implement the program's request, and correctly update the StackSet; so it will keep the new size. This should work correctly even for non-current windows.
* Otherwise, we ignore the request. As per ICCCM, we send a fake ConfigureNotify containing the new (unchanged) geometry. This is perfectly ICCCM compliant, and if it breaks your client, it's your own fault.
This patch requires setConfigureEvent, which is added to X11-extras by a patch approximately contemporaneous with this one.
This doesn't seem to work quite right (for me, anyway). I find that all transient windows now appear at (0,0). (I've not noticed the resizing behaviour, particularly, so that may well have been improved.) [...]

On Mon, 04 Jun 2007 00:03:38 +0100
Bruce Stephens
This doesn't seem to work quite right (for me, anyway). I find that all transient windows now appear at (0,0). (I've not noticed the resizing behaviour, particularly, so that may well have been improved.)
Just pushed a fix, is the problem resolved now? Cheers, Spencer Janssen

Spencer Janssen
On Mon, 04 Jun 2007 00:03:38 +0100 Bruce Stephens
wrote: This doesn't seem to work quite right (for me, anyway). I find that all transient windows now appear at (0,0). (I've not noticed the resizing behaviour, particularly, so that may well have been improved.)
Just pushed a fix, is the problem resolved now?
Yes, that fixed it.
participants (3)
-
Bruce Stephens
-
Spencer Janssen
-
Stefan O'Rear