Re: Issue 291 in xmonad: Layout.Tabbed has drawing problems when used with Layout.MultiToggle
Updates: Labels: Type-Defect Component-Contrib Comment #1 on issue 291 by vogt.adam: Layout.Tabbed has drawing problems when used with Layout.MultiToggle http://code.google.com/p/xmonad/issues/detail?id=291 Can you still reproduce this if you include this patch: Sat Dec 19 19:47:33 EST 2009 Tomas Janousek <tomi@nomi.cz> * Fix MultiToggle crashes with decorated layouts The problem was that certain layouts keep their "world" state in their value, which was thrown away and forgotten after ReleaseResources during toggle. In particular, decorated layouts store some X11 handles in them and allocate/deallocate it as appropriate. If any modification to their state is ignored, they may try to deallocate already deallocated memory, which results in a crash somewhere inside Xlib. This patch makes Transformers reversible so that nothing is ever ignored. As a side effect, layout transformers now do receive messages and messages for the base layout do not need the undo/reapply cycle -- we just pass messages to the current transformed layout and unapply the transformer when needed. (This, however, doesn't mean that the base layout is not asked to release resources on a transformer change -- we still need the transformer to release its resources and there's no way to do this without asking the base layout as well.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Comment #2 on issue 291 by fritschy: Layout.Tabbed has drawing problems when used with Layout.MultiToggle http://code.google.com/p/xmonad/issues/detail?id=291 Hi XMonad-devs. I am running on ubuntu 10.10 amd64 with XMonad 0.9.1. When having a tabbed layout and toggling decorations XMonad crashes. I can supply you with xmonad.hs, the binary and even a core file ;). I haven't yet figured if the above fix actually is _in_ ubuntu... I am on it. Cheers, Marcus
Comment #3 on issue 291 by liskni.si: Layout.Tabbed has drawing problems when used with Layout.MultiToggle http://code.google.com/p/xmonad/issues/detail?id=291 The fix is _not_ in 0.9.1 and Ubuntu package does not include it: http://changelogs.ubuntu.com/changelogs/pool/universe/x/xmonad-contrib/xmona...
Comment #4 on issue 291 by fritschy: Layout.Tabbed has drawing problems when used with Layout.MultiToggle http://code.google.com/p/xmonad/issues/detail?id=291 I figured that it might not be noted in the ubuntu changelog... but if it's not in 0.9.1 then... well, out of luck ;) Cheers, Marcus
Comment #5 on issue 291 by fritschy: Layout.Tabbed has drawing problems when used with Layout.MultiToggle http://code.google.com/p/xmonad/issues/detail?id=291 Build XMonad from darcs. Could not reproduce the issue! Feels like fixed :) Cheers, Marcus
Updates: Status: Fixed Comment #6 on issue 291 by vogt.adam: Layout.Tabbed has drawing problems when used with Layout.MultiToggle http://code.google.com/p/xmonad/issues/detail?id=291 (No comment was entered for this change.)
participants (1)
-
codesite-noreply@google.com