darcs patch: make NewTabbed use InvisibleMaybe to hid... (and 3 more)
I'm sending them all. The last one fixes a bug in NewTabbed.
andrea
Wed Sep 26 22:23:30 CEST 2007 David Roundy
On Fri, Sep 28, 2007 at 03:19:29AM +0200, Andrea Rossato wrote:
I'm sending them all. The last one fixes a bug in NewTabbed.
...
hunk ./NewTabbed.hs 94 TabState { tabsWindows :: [(Window,Window)] , scr :: Rectangle , fontS :: FontStruct -- FontSet - } + } deriving ( Show , Read )
Any reason to add this deriving back in? I liked having it removed, so that we couldn't accidentally print it, and to make it clear that we don't intend to do so.
data Tabbed a = Tabbed (InvisibleMaybe TabState) TConf hunk ./NewTabbed.hs 140 | Just ReleaseResources == fromMessage m = do d <- asks display destroyTabs $ map fst tws io $ freeFont d (fontS st) - return $ Just $ Tabbed INothin conf + return Nothing handleMess _ _ = return Nothing
I don't understand the bug that this supposedly fixes, but I'd say it introduces a bug, not the other way around. With this change, we retain references to resources that have been freed, which is definitely not a good thing. -- David Roundy Department of Physics Oregon State University
On Thu, Sep 27, 2007 at 07:08:22PM -0700, David Roundy wrote:
On Fri, Sep 28, 2007 at 03:19:29AM +0200, Andrea Rossato wrote:
+ } deriving ( Show , Read )
no actually, I though I got removed by some mess (on my side) with recording/pulling etc...
- return $ Just $ Tabbed INothin conf + return Nothing I don't understand the bug that this supposedly fixes, but I'd say it introduces a bug, not the other way around. With this change, we retain references to resources that have been freed, which is definitely not a good thing.
It was 3 and half in the morning and Spencer told me NewTabbed was bugged since it did not respond correctly to SetLayout. I thought it should be just my fault. But when I wake up, 5 minutes ago, I had a flash back: we decided that after a ReleaseReasources I *must* return a Tabbed INothin. I saw that SetLayout got removed. Andrea
participants (2)
-
Andrea Rossato -
David Roundy