darcs patch: color focussed tab differently. (and 2 more)

newer
darcs patch: make Tabbed respect...

older
darcs patch: a few modifications...

David Roundy

10 Jun 2007 10 Jun '07

4:36 p.m.

The important one here is the Decoration fix in the middle below. This makes the tabbed layout (or anything else using Decorations) respond to both expose and buttonPress events properly. David Sun Jun 10 12:57:43 PDT 2007 David Roundy * color focussed tab differently. Sun Jun 10 13:34:51 PDT 2007 David Roundy * make Decoration set the input mask appropriately. Sun Jun 10 13:35:13 PDT 2007 David Roundy * tune layout of Tabbed just a bit.

Attachments:

color-focussed-tab-differently_.dpatch (text/x-darcs-patch — 13.0 KB)

Show replies by date

Spencer Janssen

10 Jun 10 Jun

4:43 p.m.

New subject: [Xmonad] darcs patch: color focussed tab differently. (and 2 more)

On Sun, 10 Jun 2007 13:36:34 -0700 David Roundy wrote:

...

The important one here is the Decoration fix in the middle below. This makes the tabbed layout (or anything else using Decorations) respond to both expose and buttonPress events properly.

David

Sun Jun 10 12:57:43 PDT 2007 David Roundy * color focussed tab differently.

Sun Jun 10 13:34:51 PDT 2007 David Roundy * make Decoration set the input mask appropriately.

Sun Jun 10 13:35:13 PDT 2007 David Roundy * tune layout of Tabbed just a bit.

Applied, thanks.

Andrea Rossato

5:09 p.m.

New subject: [Xmonad] darcs patch: color focussed tab differently. (and 2 more)

On Sun, Jun 10, 2007 at 01:36:34PM -0700, David Roundy wrote:

...

The important one here is the Decoration fix in the middle below. This makes the tabbed layout (or anything else using Decorations) respond to both expose and buttonPress events properly.

I'm having trouble compiling with XMonadXontrib.Tabbed: XMonadContrib/Decoration.hs:26:27: No instance for (Eq ModifyWindows) and that's sound correct here. What are the bits I'm missing? Thanks, andrea

David Roundy

5:33 p.m.

New subject: [Xmonad] darcs patch: color focussed tab differently. (and 2 more)

On Sun, Jun 10, 2007 at 11:09:20PM +0200, Andrea Rossato wrote:

...

On Sun, Jun 10, 2007 at 01:36:34PM -0700, David Roundy wrote:

...
The important one here is the Decoration fix in the middle below. This makes the tabbed layout (or anything else using Decorations) respond to both expose and buttonPress events properly.

I'm having trouble compiling with XMonadXontrib.Tabbed: XMonadContrib/Decoration.hs:26:27: No instance for (Eq ModifyWindows)

and that's sound correct here. What are the bits I'm missing?

Argh. I've just sent it in. I don't know how I missed it before. -- David Roundy http://www.darcs.net

Andrea Rossato

6:27 p.m.

New subject: [Xmonad] darcs patch: color focussed tab differently. (and 2 more)

On Sun, Jun 10, 2007 at 02:33:13PM -0700, David Roundy wrote:

...

Argh. I've just sent it in. I don't know how I missed it before.

great! we have tabs! Nice stuff to study too. Thanks. by, gaps are not taken into account: tabs are just in the top of the window if I understand correctly how newDecoration is used in XMonadContrib.Tabbed. That interferes with my statusbar. It shouldn't be difficult to change that. 'Night. Andrea

Jason Creighton

7:17 p.m.

New subject: [Xmonad] darcs patch: color focussed tab differently. (and 2 more)

On Mon, Jun 11, 2007 at 12:27:56AM +0200, Andrea Rossato wrote:

...

On Sun, Jun 10, 2007 at 02:33:13PM -0700, David Roundy wrote:

...
Argh. I've just sent it in. I don't know how I missed it before.

great! we have tabs!

Nice stuff to study too. Thanks.

by, gaps are not taken into account: tabs are just in the top of the window if I understand correctly how newDecoration is used in XMonadContrib.Tabbed. That interferes with my statusbar. It shouldn't be difficult to change that.

Thanks for the report. I've sent a patch that fixes this; it'll probably be applied within a day or so. Jason Creighton

6556

Age (days ago)

6556

Last active (days ago)

List overview

Download

5 comments

4 participants

participants (4)

Andrea Rossato
David Roundy
Jason Creighton
Spencer Janssen