Issue 533 in xmonad: clearUrgency should be exported from XMonad.Hooks.UrgencyHook
Status: New Owner: ---- New issue 533 by JohnTy...@gmail.com: clearUrgency should be exported from XMonad.Hooks.UrgencyHook http://code.google.com/p/xmonad/issues/detail?id=533 I was trying to make it such that windows which are banished off screen on hidden scratch pad workspaces *never* get urgency set. It was not possible to do so without making my own Urgency Hook, which was fine, except that in order to make it I had no choice but to modify the source and add clearUrgency to the export list. Since "clearUrgents" is exported, which just applies "clearUrgency" to all windows, I don't see why the latter shouldn't also be available. data FilterUrgencyHook = FilterUrgencyHook [String] instance UrgencyHook FilterUrgencyHook where urgencyHook (FilterUrgencyHook skips) w = do ws <- gets windowset case W.findTag w ws of Just tag -> when (tag `elem` skips) (clearUrgency w) _ -> return () -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings
Comment #1 on issue 533 by JohnTy...@gmail.com: clearUrgency should be exported from XMonad.Hooks.UrgencyHook http://code.google.com/p/xmonad/issues/detail?id=533 This patch just adds clearUrgency to the export list. Attachments: xmonad-contrib-export-clearUrgency.patch 702 bytes -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings
Updates: Status: Fixed Comment #2 on issue 533 by vogt.a...@gmail.com: clearUrgency should be exported from XMonad.Hooks.UrgencyHook http://code.google.com/p/xmonad/issues/detail?id=533 A patch for #1 is now in the official repo. We could add this function to the module too, if you think that would be useful. filterUrgencyHook skips w = do ws <- gets windowset case W.findTag w ws of Just tag -> when (tag `elem` skips) (clearUrgency w) _ -> return () -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings
Comment #3 on issue 533 by JohnTy...@gmail.com: clearUrgency should be exported from XMonad.Hooks.UrgencyHook http://code.google.com/p/xmonad/issues/detail?id=533 That would be good, yeah. Maybe I'm misunderstanding this, but does `filterUrgencyHook` not need to be an instance of UrgencyHook? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings
Comment #4 on issue 533 by JohnTy...@gmail.com: clearUrgency should be exported from XMonad.Hooks.UrgencyHook http://code.google.com/p/xmonad/issues/detail?id=533 That would be good, yeah. Would that imply that I no longer need to implement the UrgencyHook instance as I did above? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings
Comment #5 on issue 533 by vogt.a...@gmail.com: clearUrgency should be exported from XMonad.Hooks.UrgencyHook http://code.google.com/p/xmonad/issues/detail?id=533 There is an instance UrgencyHook (Window -> X ()). Previously you had to write a separate data&instance for each urgencyhook. This is no longer the case because the urgencyhook doesn't have to be stored in a layout anymore (due to the addition of the handleEventHook a couple years back). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings
Comment #6 on issue 533 by JohnTy...@gmail.com: clearUrgency should be exported from XMonad.Hooks.UrgencyHook http://code.google.com/p/xmonad/issues/detail?id=533 This sounds good. Sorry to be a tool, but what does that imply for my config? For example if it looked like this before xmonad $ ewmh $ withUrgencyHook (FilterUrgencyHook ["NSP", "SP"]) defaultConfig then I'd expect something like.... xmonad $ ewmh $ withUrgencyHook (filterUrgencyHook ["NSP", "SP"]) defaultConfig now? Also, when (roughly) can I expect this to hit a stable release? I'm using the latest release from xmonad.org but not darcs. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings
Comment #7 on issue 533 by vogt.a...@gmail.com: clearUrgency should be exported from XMonad.Hooks.UrgencyHook http://code.google.com/p/xmonad/issues/detail?id=533 You're exactly right. A release won't happen for a several months I expect. Or it might be sooner if ghc-7.8 breaks things. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings
Comment #8 on issue 533 by vogt.a...@gmail.com: clearUrgency should be exported from XMonad.Hooks.UrgencyHook http://code.google.com/p/xmonad/issues/detail?id=533 You're exactly right. Taking a closer look it seems like filtering might be better off done in the UrgencyConfig but I will leave things as-is for now. A release won't happen for a several months I expect. Or it might be sooner if ghc-7.8 breaks things. As for trying it out, you can `cabal install http://code.haskell.org/xmonad/xmonad.tar.gz http://code.haskell.org/XMonadContrib/XMonadContrib.tar.gz', if darcs is too much trouble. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings
participants (1)
-
codesite-noreply＠google.com