
Hi, Please find the two patches in the attachment with this mail 2 patches for repository http://code.haskell.org/XMonadContrib: Mon Mar 5 21:42:40 IST 2012 crodjer@gmail.com * ShowWName: Fix flash location by screen rectangle In case of using this hook with multiple monitors, the Tag flash was not following the screen's coordinates. This patch shifts the new window created for flash according to the Rectangle defined by the screen. Mon Mar 5 22:15:17 IST 2012 crodjer@gmail.com * ShowWName: Increase horizontal padding for flash Currently the flash window width leaves a very small amount of padding. This patch adds some extra horizontal width, governed by text width and length. -- Rohan

On Mon, Mar 5, 2012 at 1:32 PM, Rohan Jain
Hi,
Please find the two patches in the attachment with this mail
2 patches for repository http://code.haskell.org/XMonadContrib:
Mon Mar 5 21:42:40 IST 2012 crodjer@gmail.com * ShowWName: Fix flash location by screen rectangle
In case of using this hook with multiple monitors, the Tag flash was not following the screen's coordinates. This patch shifts the new window created for flash according to the Rectangle defined by the screen.
Mon Mar 5 22:15:17 IST 2012 crodjer@gmail.com * ShowWName: Increase horizontal padding for flash
Currently the flash window width leaves a very small amount of padding. This patch adds some extra horizontal width, governed by text width and length.
If no one has any objections, I will push this in 10 days if it compiles. -- gwern http://www.gwern.net

Quoting Rohan Jain
Hi,
Please find the two patches in the attachment with this mail
2 patches for repository http://code.haskell.org/XMonadContrib:
Mon Mar 5 21:42:40 IST 2012 crodjer@gmail.com * ShowWName: Fix flash location by screen rectangle
In case of using this hook with multiple monitors, the Tag flash was not following the screen's coordinates. This patch shifts the new window created for flash according to the Rectangle defined by the screen.
Applied, thanks.
Mon Mar 5 22:15:17 IST 2012 crodjer@gmail.com * ShowWName: Increase horizontal padding for flash
Currently the flash window width leaves a very small amount of padding. This patch adds some extra horizontal width, governed by text width and length.
This patch seems to add smaller and smaller padding the larger the text inside. Am I reading that right? Is that reasonable? ~d

On Fri, Mar 9, 2012 at 15:42,
Mon Mar 5 22:15:17 IST 2012 crodjer@gmail.com * ShowWName: Increase horizontal padding for flash
Currently the flash window width leaves a very small amount of padding. This patch adds some extra horizontal width, governed by text width and length.
This patch seems to add smaller and smaller padding the larger the text inside. Am I reading that right? Is that reasonable?
If the idea is to make sure the window has a reasonable size, it makes sense to pad it larger for smaller internal text because it doesn't need (any/as much) padding if the text already forces it to have a reasonable size. ("Reasonable" defined as "easily visible") -- brandon s allbery allbery.b@gmail.com wandering unix systems administrator (available) (412) 475-9364 vm/sms

On 15:53 -0500 / 9 Mar, Brandon Allbery wrote: Yes, Increasing the visibility of the flash was my primary target here. The patch results in relatively more significant amount of padding in case of smaller sized tags. Also I think the horizontal padding makes it go better with the existing vertical pad. This is a subjective view, so we can have a configuration option which exposes a multiplier to a unit character length lets say swn_hz_pad . If this seems acceptable, I will post a patch for this. -- Rohan Jain
On Fri, Mar 9, 2012 at 15:42,
wrote: Mon Mar 5 22:15:17 IST 2012 crodjer@gmail.com * ShowWName: Increase horizontal padding for flash
Currently the flash window width leaves a very small amount of padding. This patch adds some extra horizontal width, governed by text width and length.
This patch seems to add smaller and smaller padding the larger the text inside. Am I reading that right? Is that reasonable?
If the idea is to make sure the window has a reasonable size, it makes sense to pad it larger for smaller internal text because it doesn't need (any/as much) padding if the text already forces it to have a reasonable size. ("Reasonable" defined as "easily visible")
-- brandon s allbery allbery.b@gmail.com wandering unix systems administrator (available) (412) 475-9364 vm/sms
_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad

Yes, Increasing the visibility of the flash was my primary target here. The patch results in relatively more significant amount of padding in case of smaller sized tags.
If the idea is to make sure the window has a reasonable size, it makes sense to pad it larger for smaller internal text because it doesn't need (any/as much) padding if the text already forces it to have a reasonable size. ("Reasonable" defined as "easily visible")
Okay, pushed. ~d

This 2-patches bundle was just applied to http://code.haskell.org/XMonadContrib: 20120305161240 crodjer@gmail.com * ShowWName: Fix flash location by screen rectangle In case of using this hook with multiple monitors, the Tag flash was not following the screen's coordinates. This patch shifts the new window created for flash according to the Rectangle defined by the screen. 20120305164517 crodjer@gmail.com * ShowWName: Increase horizontal padding for flash Currently the flash window width leaves a very small amount of padding. This patch adds some extra horizontal width, governed by text width and length. -- This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__code.haskell.org_XMonadContrib.html...
participants (5)
-
Brandon Allbery
-
darcswatch@nomeata.de
-
Gwern Branwen
-
Rohan Jain
-
wagnerdm@seas.upenn.edu