darcs patch: Run.hs, SshPrompt.hs, ShellPrompt.hs: mv... (and 3 more)

newer
darcs patch: make setLayout a bit...

gwern0＠gmail.com

23 Oct 2007 23 Oct '07

8:40 p.m.

Tue Oct 23 20:13:41 EDT 2007 gwern0@gmail.com * Run.hs, SshPrompt.hs, ShellPrompt.hs: mv runInXTerm back into Run.hs per suggestions Tue Oct 23 20:16:28 EDT 2007 gwern0@gmail.com * Run.hs: +my suggested runInTerm general function Tue Oct 23 20:18:56 EDT 2007 gwern0@gmail.com * Run.hs: specialize runInXTerm to use runInTerm per my mailing list suggestion Tue Oct 23 20:39:11 EDT 2007 gwern0@gmail.com * Run.hs: do my usual segregation into safe and unsafe runInTerms

Attachments:

run_hs_-sshprompt_hs_-shellprompt_hs_-mv-runinxterm-back-into-run_hs-per-suggestions.dpatch (text/x-darcs-patch — 15.7 KB)

Show replies by date

Spencer Janssen

24 Oct 24 Oct

6:50 a.m.

New subject: [Xmonad] darcs patch: Run.hs, SshPrompt.hs, ShellPrompt.hs: mv... (and 3 more)

On Tuesday 23 October 2007 19:40:04 gwern0@gmail.com wrote:

...

Tue Oct 23 20:13:41 EDT 2007 gwern0@gmail.com * Run.hs, SshPrompt.hs, ShellPrompt.hs: mv runInXTerm back into Run.hs per suggestions

Tue Oct 23 20:16:28 EDT 2007 gwern0@gmail.com * Run.hs: +my suggested runInTerm general function

Tue Oct 23 20:18:56 EDT 2007 gwern0@gmail.com * Run.hs: specialize runInXTerm to use runInTerm per my mailing list suggestion

Tue Oct 23 20:39:11 EDT 2007 gwern0@gmail.com * Run.hs: do my usual segregation into safe and unsafe runInTerms

Applied. I don't like these "safe" and "unsafe" names, please consider something more descriptive. Cheers, Spencer Janssen

Gwern Branwen

7:32 a.m.

New subject: [Xmonad] darcs patch: Run.hs, SshPrompt.hs, ShellPrompt.hs: mv... (and 3 more)

On 2007.10.24 05:50:39 -0500, Spencer Janssen scribbled 0 lines:

...

On Tuesday 23 October 2007 19:40:04 gwern0@gmail.com wrote:

...
Tue Oct 23 20:13:41 EDT 2007 gwern0@gmail.com * Run.hs, SshPrompt.hs, ShellPrompt.hs: mv runInXTerm back into Run.hs per suggestions

Tue Oct 23 20:16:28 EDT 2007 gwern0@gmail.com * Run.hs: +my suggested runInTerm general function

Tue Oct 23 20:18:56 EDT 2007 gwern0@gmail.com * Run.hs: specialize runInXTerm to use runInTerm per my mailing list suggestion

Tue Oct 23 20:39:11 EDT 2007 gwern0@gmail.com * Run.hs: do my usual segregation into safe and unsafe runInTerms

Applied.

I don't like these "safe" and "unsafe" names, please consider something more descriptive.

Cheers, Spencer Janssen

Does anyone have any suggestions? I originally chose safe/unsafe because I regard not going through the shell as safer, less error-prone. What would be better? 'shell'/'shelless'? -- gwern EODG S.A.I.C. FAS York FDM rs9512c wwics Capricorn Unit HERF

Devin Mullins

8:49 a.m.

New subject: [Xmonad] darcs patch: Run.hs, SshPrompt.hs, ShellPrompt.hs: mv... (and 3 more)

On Wed, Oct 24, 2007 at 07:32:05AM -0400, Gwern Branwen wrote:

...

Does anyone have any suggestions? I originally chose safe/unsafe because I regard not going through the shell as safer, less error-prone. What would be better? 'shell'/'shelless'? spawnUnescaped / spawnEscaped?

I know the latter isn't actually escaping anything, but it'll have that perception to those more familiar with the shell than with exec*(). Devin

David Roundy

10:18 a.m.

New subject: [Xmonad] darcs patch: Run.hs, SshPrompt.hs, ShellPrompt.hs: mv... (and 3 more)

On Wed, Oct 24, 2007 at 07:32:05AM -0400, Gwern Branwen wrote:

...

On 2007.10.24 05:50:39 -0500, Spencer Janssen scribbled 0 lines:

...
On Tuesday 23 October 2007 19:40:04 gwern0@gmail.com wrote:

...
Tue Oct 23 20:13:41 EDT 2007 gwern0@gmail.com * Run.hs, SshPrompt.hs, ShellPrompt.hs: mv runInXTerm back into Run.hs per suggestions

Tue Oct 23 20:16:28 EDT 2007 gwern0@gmail.com * Run.hs: +my suggested runInTerm general function

Tue Oct 23 20:18:56 EDT 2007 gwern0@gmail.com * Run.hs: specialize runInXTerm to use runInTerm per my mailing list suggestion

Tue Oct 23 20:39:11 EDT 2007 gwern0@gmail.com * Run.hs: do my usual segregation into safe and unsafe runInTerms

Applied.

I don't like these "safe" and "unsafe" names, please consider something more descriptive.

Cheers, Spencer Janssen

Does anyone have any suggestions? I originally chose safe/unsafe because I regard not going through the shell as safer, less error-prone. What would be better? 'shell'/'shelless'?

I'd definitely use the word "shell" in the name. Using a shell really is no less safe than using no shell, in my opinion, unless you are using potentially hostile input. But if we're exec-ing potentially hostile input, it takes a lot more than passing the arguments in verabatim to ensure that the resulting action is safe. How about something like: execShell and exec, which describe what is actually being done? Or just append ViaShell to the functions that go through the shell? -- David Roundy Department of Physics Oregon State University

Brandon S. Allbery KF8NH

11:02 a.m.

New subject: [Xmonad] darcs patch: Run.hs, SshPrompt.hs, ShellPrompt.hs: mv... (and 3 more)

On Oct 24, 2007, at 7:32 , Gwern Branwen wrote:

...

Does anyone have any suggestions? I originally chose safe/unsafe because I regard not going through the shell as safer, less error- prone. What would be better? 'shell'/'shelless'?

spawn / spawnViaShell ? -- brandon s. allbery [solaris,freebsd,perl,pugs,haskell] allbery@kf8nh.com system administrator [openafs,heimdal,too many hats] allbery@ece.cmu.edu electrical and computer engineering, carnegie mellon university KF8NH

Valery V. Vorotyntsev

8:24 a.m.

New subject: [Xmonad] darcs patch: Run.hs, SshPrompt.hs, ShellPrompt.hs: mv... (and 3 more)

On 10/24/07, Spencer Janssen wrote:

...

I don't like these "safe" and "unsafe" names, please consider something more descriptive.

s/unsafeSpawn/spawn/ s/safeSpawn/spawnVerbatim/ ? -- vvv

6419

Age (days ago)

6419

Last active (days ago)

List overview

Download

6 comments

7 participants

participants (7)

Brandon S. Allbery KF8NH
David Roundy
Devin Mullins
Gwern Branwen
gwern0＠gmail.com
Spencer Janssen
Valery V. Vorotyntsev