Issue 125 in xmonad: Tabbed layout not working anymore

Issue 125: Tabbed layout not working anymore http://code.google.com/p/xmonad/issues/detail?id=125 Comment #16 by andrea.rossato:
The only thing that remains, from a user point of view, is the ability to click on the tabs (decorations) to switch to the window.
this requires a change in the way we handle messages. Basically, a layout modifier is not allowed to call "focus w" (the function to place a window in focus), because that modifies the stack the layout modifier is operating with. As I wrote here: http://www.haskell.org/pipermail/xmonad/2008-January/004398.html I do not really grasp the hows and whys, but I'm sure it's true. I think this issue is the same of issue #111. (but I remember there should be a similar issue, but I cannot find it presently).
One question: shouldn't 'windowRemove' be used inside 'tabbed' in 'XMonad.Layout.Tabbed'. So that users don't have to remember to apply it to 'tabbed'?
yes, you are right. But I didn't because of that linker issue. I thought that first we must test the patch, and possibly understand if it breaks ghc-6.6.1 compatibility, that would be quite an issue. Cheers, Andrea I'm accepting this bug. See: http://www.haskell.org/pipermail/xmonad/2008-February/004533.html Issue attribute updates: Status: Accepted Owner: andrea.rossato -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings

On Fri, Feb 01, 2008 at 04:44:04AM -0800, codesite-noreply@google.com wrote:
Issue 125: Tabbed layout not working anymore http://code.google.com/p/xmonad/issues/detail?id=125
Comment #16 by andrea.rossato:
The only thing that remains, from a user point of view, is the ability to click on the tabs (decorations) to switch to the window.
this requires a change in the way we handle messages. Basically, a layout modifier is not allowed to call "focus w" (the function to place a window in focus), because that modifies the stack the layout modifier is operating with. As I wrote here: http://www.haskell.org/pipermail/xmonad/2008-January/004398.html I do not really grasp the hows and whys, but I'm sure it's true.
Layouts can call 'focus w' in their message handlers -- in fact this is how the old tabbed layout worked.
I think this issue is the same of issue #111. (but I remember there should be a similar issue, but I cannot find it presently).
Issue #111 only comes into play when a message handler changes the set of visible workspaces. The old tabbed hit this issue when the user clicks a tab on an inactive workspace. Cheers, Spencer Janssen

On Feb 1, 2008 4:29 PM, Spencer Janssen
Layouts can call 'focus w' in their message handlers -- in fact this is how the old tabbed layout worked.
No, they can only call 'focus w' in response to messages sent by sentMessage, not to messages sent by broadcastMessage. Which is why even the old tabbed is currently broken. David
participants (3)
-
codesite-noreply@google.com
-
David Roundy
-
Spencer Janssen