Issue 353 in xmonad: XMonad.Prompt.Window's prefix search isn't always the best option
Status: New Owner: ---- New issue 353 by novas0x2a: XMonad.Prompt.Window's prefix search isn't always the best option http://code.google.com/p/xmonad/issues/detail?id=353 XMonad.Prompt uses isPrefixOf as the filter predicate for doPrompt. That's not always the best option- for example, I prefer isInfixOf. Here's a patch that makes it an option. It's cut against 0.9.1. This implementation is only one of many possible ways for me to get my way, but I'm not set on this particular method :) Attachments: 0001-Add-a-predicate-option-to-XMonad.Prompt.patch 2.1 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Updates: Status: Started Owner: vogt.adam Labels: Type-Enhancement Component-Contrib Priority-Medium Comment #1 on issue 353 by vogt.adam: XMonad.Prompt.Window's prefix search isn't always the best option http://code.google.com/p/xmonad/issues/detail?id=353 Thanks for the patch! I have a couple suggestions (mainly documentation): The comment needs a '^' to show up in the haddock documentation:
, searchPredicate :: String -> String -> Bool -- ^ Filter predicate for doPrompt
The following is helpful to prevent confusion as to which string is which (I'm 90% sure that this is valid haddock markup, do test it though):
, searchPredicate :: String -- ^ typed string -> String -- ^ possible completion -> Bool -- ^ is a valid completion
And lastly, could you send these changes as a darcs patch (against the current contrib repo)? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Comment #2 on issue 353 by novas0x2a: XMonad.Prompt.Window's prefix search isn't always the best option http://code.google.com/p/xmonad/issues/detail?id=353 Here's a new one. I changed the comment to support haddock, but it seems that documenting the arguments of a function that is also a record entry isn't supported (causes a parse error). Hopefully the way I did it makes sense. Attachments: add-a-search-predicate-option-to-xmonad_prompt.dpatch 21.6 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Updates: Status: Fixed Comment #3 on issue 353 by vogt.adam: XMonad.Prompt.Window's prefix search isn't always the best option http://code.google.com/p/xmonad/issues/detail?id=353 Applied, thanks. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
participants (1)
-
codesite-noreply＠google.com